Re: [PATCH 3/6] can: janz-ican3: fix error and byte counters

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 2012 bytes --]

On 07/19/2012 05:54 PM, Ira W. Snyder wrote:
> From: "Ira W. Snyder" <iws@ovro.caltech.edu>
> 
> The error and byte counter statistics were being incremented
> incorrectly. For example, a TX error would be counted both in tx_errors
> and rx_errors.
> 
> This corrects the problem so that tx_errors and rx_errors are only
> incremented for errors caused by packets sent to the bus. Error packets
> generated by the driver are not counted.
> 
> The byte counters are only increased for packets which are actually
> transmitted or received from the bus. Error packets generated by the
> driver are not counted.
> 
> Signed-off-by: Ira W. Snyder <iws@ovro.caltech.edu>
> ---
> 
> Changes for this version:
> - for RX overflow errors, both rx_over_errors and rx_errors are incremented
> 
>  drivers/net/can/janz-ican3.c |   11 ++++++-----
>  1 files changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/can/janz-ican3.c b/drivers/net/can/janz-ican3.c
> index ea1919e..14d5abc 100644
> --- a/drivers/net/can/janz-ican3.c
> +++ b/drivers/net/can/janz-ican3.c
> @@ -907,8 +907,8 @@ static void ican3_handle_msglost(struct ican3_dev *mod, struct ican3_msg *msg)
>  	if (skb) {
>  		cf->can_id |= CAN_ERR_CRTL;
>  		cf->data[1] = CAN_ERR_CRTL_RX_OVERFLOW;
> +		stats->rx_over_errors++;
>  		stats->rx_errors++;
> -		stats->rx_bytes += cf->can_dlc;
>  		netif_rx(skb);
>  	}
>  }
> @@ -982,7 +982,6 @@ static int ican3_handle_cevtind(struct ican3_dev *mod, struct ican3_msg *msg)
>  
>  		dev_dbg(mod->dev, "bus error interrupt\n");
>  		mod->can.can_stats.bus_error++;
> -		stats->rx_errors++;
                ^^^^^^^^^^^^^^^^^^

What about this one? Accidentally removed?

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]