Re: [PATCH v10 1/1] ethdev: add support to provide link type

[Thomas Monjalon <thomas@monjalon.net>]

10/09/2025 02:50, Stephen Hemminger:
> On Mon, 8 Sep 2025 14:21:48 +0530
> <skori@marvell.com> wrote:
> 
> > From: Sunil Kumar Kori <skori@marvell.com>
> > 
> > Adding link type parameter to provide the type
> > of port like twisted pair, fibre etc.
> > 
> > Also added an API to convert the RTE_ETH_LINK_CONNECTOR_XXX
> > to a readable string.
> > 
> > Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> > Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> > ---
> > v9..v10:
> >  - Rebase on top of next-net:main branch.
> > v8..v9:
> >  - Adds 25.11 release notes.
> > v7..v8:
> >  - Add documentation for invalid link type.
> >  - Remove trace point from API.
> >  - Rebase on next-net.
> > v6..v7:
> >  - Replace link_type to link_connector.
> >  - Update comments.
> > v5..v6:
> >  - Fix doxygen error.
> > v4..v5:                                                                                             
> >  - Convert link type to connector.
> >  - Fix build error on Windows.
> >  - Handle comsmetic review comments.
> > v3..v4:
> >  - Convert #define into enum.
> >  - Enhance comments for each port link type.
> >  - Fix test failures.
> > v2..v3
> >  - Extend link type list as per suggestion.
> > 
> >  app/test/test_ethdev_link.c            | 18 +++++----
> >  doc/guides/rel_notes/release_25_11.rst |  9 +++++
> >  lib/ethdev/rte_ethdev.c                | 45 ++++++++++++++++++++-
> >  lib/ethdev/rte_ethdev.h                | 54 ++++++++++++++++++++++++++
> >  4 files changed, 117 insertions(+), 9 deletions(-)
> 
> Queued to next-net.
> Fixed the fuzz (file offset) differences in release note and test

Please no, I did some comments on this v10.
I wait for a reply, and probably a new version.