From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonyoung Shim Subject: Re: [PATCH 2/2] drm/exynos: Modifying exynos drm fimd to support exynos5 Date: Fri, 20 Jul 2012 15:49:42 +0900 Message-ID: <5008FF86.9000606@samsung.com> References: <1341577694-28937-1-git-send-email-l.krishna@samsung.com> <1341577694-28937-3-git-send-email-l.krishna@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by gabe.freedesktop.org (Postfix) with ESMTP id B00259EB6B for ; Thu, 19 Jul 2012 23:49:33 -0700 (PDT) Received: from epcpsbgm1.samsung.com (mailout3.samsung.com [203.254.224.33]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M7G0073E5I0JDS0@mailout3.samsung.com> for dri-devel@lists.freedesktop.org; Fri, 20 Jul 2012 15:49:32 +0900 (KST) Received: from [10.90.51.60] by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0M7G00H9Q5MKRRL0@mmp1.samsung.com> for dri-devel@lists.freedesktop.org; Fri, 20 Jul 2012 15:49:32 +0900 (KST) In-reply-to: <1341577694-28937-3-git-send-email-l.krishna@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Leela Krishna Amudala Cc: inki.dae@samsung.com, olofj@google.com, laurent.pinchart@ideasonboard.com, dri-devel@lists.freedesktop.org, Prathyush K List-Id: dri-devel@lists.freedesktop.org Hi, Some minor commants. On 07/06/2012 09:28 PM, Leela Krishna Amudala wrote: > From: Prathyush K > > The name of the exynos drm fimd device is renamed to exynos-drm-fimd > and two ids are created for exynos4-fb and exynos5-fb. Please write the subject clearly this patch is to do what. How about "add platform_device_id table for exynos5 fimd"? > > Signed-off-by: Prathyush K > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > index 37769cf..f7bb0a0 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > @@ -1092,6 +1092,16 @@ static const struct of_device_id drm_fimd_dt_match[] = { > MODULE_DEVICE_TABLE(of, drm_fimd_dt_match); > #endif > > +static struct platform_device_id exynos_drm_driver_ids[] = { Use fimd_ prefix, such as "fimd_driver_ids". > + { > + .name = "exynos4-fb", > + }, { > + .name = "exynos5-fb", > + }, > + {}, > +}; > +MODULE_DEVICE_TABLE(platform, exynos_drm_driver_ids); > + > static const struct dev_pm_ops fimd_pm_ops = { > SET_SYSTEM_SLEEP_PM_OPS(fimd_suspend, fimd_resume) > SET_RUNTIME_PM_OPS(fimd_runtime_suspend, fimd_runtime_resume, NULL) > @@ -1100,8 +1110,9 @@ static const struct dev_pm_ops fimd_pm_ops = { > struct platform_driver fimd_driver = { > .probe = fimd_probe, > .remove = __devexit_p(fimd_remove), > + .id_table = exynos_drm_driver_ids, > .driver = { > - .name = "exynos4-fb", > + .name = "exynos-drm-fimd", > .owner = THIS_MODULE, > .pm = &fimd_pm_ops, > .of_match_table = of_match_ptr(drm_fimd_dt_match), Thanks.