All of lore.kernel.org
 help / color / mirror / Atom feed
From: Holger Brunck <holger.brunck@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/2] kirkwood: implement kw_sdram_bs_set()
Date: Fri, 20 Jul 2012 14:30:07 +0200	[thread overview]
Message-ID: <50094F4F.1000104@keymile.com> (raw)
In-Reply-To: <201207201340.55566.marek.vasut@gmail.com>

Hi Marek, hi Prafulla,

On 07/20/2012 01:40 PM, Marek Vasut wrote:
> Dear Prafulla Wadaskar,
> 
> [...]
> 
>>> diff --git a/arch/arm/cpu/arm926ejs/kirkwood/dram.c
>>> b/arch/arm/cpu/arm926ejs/kirkwood/dram.c
>>> index 181b3e7..d938578 100644
>>> --- a/arch/arm/cpu/arm926ejs/kirkwood/dram.c
>>> +++ b/arch/arm/cpu/arm926ejs/kirkwood/dram.c
>>> @@ -32,6 +32,12 @@ DECLARE_GLOBAL_DATA_PTR;
>>>
>>>  #define KW_REG_CPUCS_WIN_BAR(x)		(KW_REGISTER(0x1500) + (x *
>>>
>>> 0x08))
>>>
>>>  #define KW_REG_CPUCS_WIN_SZ(x)		(KW_REGISTER(0x1504) + (x *
>>>
>>> 0x08))
>>
>> Hi Gerlando
>> I have a full ack for this patch.
>> But I would like to ask you-
>> Since dram.c is going through this change and macros are being used in
>> stead of c-struct for DRAM register variables. This is being one of the
>> todo item pending from long time.
>>
>> Would you like to convert macros to c-struct definition in this file?
> 
> Certainly, but let's get this applied first.
> 
> [...]
> 

I have done a v3 version of this patchserie with Prafullas inputs. Gerlando is
not in these days.

I'll send the updates soon... I have already tested them on km_kirkwood.

Regards
Holger

  reply	other threads:[~2012-07-20 12:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-05 14:28 [U-Boot] [PATCH 1/2] kirkwood: implement kw_sdram_bs_set() Gerlando Falauto
2012-07-05 14:28 ` [U-Boot] [PATCH 2/2] km_arm: enable SDRAM window size fixup Gerlando Falauto
2012-07-05 15:38 ` [U-Boot] [PATCH 1/2] kirkwood: implement kw_sdram_bs_set() Marek Vasut
2012-07-05 15:44   ` Gerlando Falauto
2012-07-05 15:51     ` Marek Vasut
2012-07-06 11:50 ` [U-Boot] [PATCH v2 " Gerlando Falauto
2012-07-06 15:41   ` Marek Vasut
2012-07-20  6:15   ` Prafulla Wadaskar
2012-07-20 11:40     ` Marek Vasut
2012-07-20 12:30       ` Holger Brunck [this message]
2012-07-06 11:50 ` [U-Boot] [PATCH v2 2/2] km_arm: enable SDRAM window size fixup Gerlando Falauto
2012-07-20  6:30   ` Prafulla Wadaskar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50094F4F.1000104@keymile.com \
    --to=holger.brunck@keymile.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.