From: Adrian Hunter <adrian.hunter@intel.com>
To: merez@codeaurora.org
Cc: Jaehoon Chung <jh80.chung@samsung.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
Chris Ball <cjb@laptop.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Konstantin Dorfman <kdorfman@codeaurora.org>,
"svenkatr@ti.com" <svenkatr@ti.com>,
Saugata Das <saugata.das@linaro.org>,
Ulf Hansson <ulf.hansson@stericsson.com>,
Per FORLIN <per.forlin@stericsson.com>,
Hanumath Prasad <hanumath.prasad@stericsson.com>,
Sebastian Rasmussen <sebras@gmail.com>,
"Dong, Chuanxiao" <chuanxiao.dong@intel.com>
Subject: Re: [RESEND PATCH v10] mmc: support BKOPS feature for eMMC
Date: Fri, 20 Jul 2012 15:57:04 +0300 [thread overview]
Message-ID: <500955A0.10205@intel.com> (raw)
In-Reply-To: <0af2721026286ee4d196ead20848664e.squirrel@www.codeaurora.org>
On 20/07/12 14:58, merez@codeaurora.org wrote:
>
> On Thu, July 19, 2012 8:12 am, Jaehoon Chung wrote:
>> +void mmc_start_bkops(struct mmc_card *card, bool from_exception)
>> +{
>> + int err;
>> + int timeout;
>> + bool use_busy_signal;
>> +
>> + BUG_ON(!card);
>> +
>> + if (!card->ext_csd.bkops_en || mmc_card_doing_bkops(card) ||
>> + !(card->host->caps2 & MMC_CAP2_BKOPS))
>> + return;
> To my opinion, the host cannot decide not to support BKOPs if it is
> enabled by the card. In such a case, the card will expect the host to
> start the BKOPs and may get into performance degradation.
> I think the MMC_CAP2_BKOPS should be removed.
> Does everyone agree or do I miss something?
I agree. The spec says of bkops_en "Host is indicating that it shall
periodically write to BKOPS_START field to manually start
background operations."
next prev parent reply other threads:[~2012-07-20 12:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 15:12 [RESEND PATCH v10] mmc: support BKOPS feature for eMMC Jaehoon Chung
2012-07-20 11:58 ` merez
2012-07-20 12:57 ` Adrian Hunter [this message]
2012-07-23 1:28 ` Jaehoon Chung
2012-07-23 9:14 ` merez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500955A0.10205@intel.com \
--to=adrian.hunter@intel.com \
--cc=chuanxiao.dong@intel.com \
--cc=cjb@laptop.org \
--cc=hanumath.prasad@stericsson.com \
--cc=jh80.chung@samsung.com \
--cc=kdorfman@codeaurora.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=merez@codeaurora.org \
--cc=per.forlin@stericsson.com \
--cc=saugata.das@linaro.org \
--cc=sebras@gmail.com \
--cc=svenkatr@ti.com \
--cc=ulf.hansson@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.