From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] powerpc: Stack Pointer must be 16 aligned
Date: Fri, 20 Jul 2012 16:12:49 -0500 [thread overview]
Message-ID: <5009C9D1.70601@freescale.com> (raw)
In-Reply-To: <1342776046-25513-1-git-send-email-Joakim.Tjernlund@transmode.se>
On 07/20/2012 04:20 AM, Joakim Tjernlund wrote:
> The PowerPC ABI mandates the SP to be 16 bytes aligned, make is so.
>
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> ---
> arch/powerpc/lib/board.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git arch/powerpc/lib/board.c arch/powerpc/lib/board.c
> index d5b75e5..dc7cc40 100644
> --- arch/powerpc/lib/board.c
> +++ arch/powerpc/lib/board.c
> @@ -521,9 +521,8 @@ void board_init_f(ulong bootflag)
> addr_sp -= 16;
> addr_sp &= ~0xF;
> s = (ulong *) addr_sp;
> - *s-- = 0;
> - *s-- = 0;
> - addr_sp = (ulong) s;
> + *s = 0; /* NULL Back Chain */
> + *--s = 0; /* NULL LR */
Same problems as in patch 2/2.
-Scott
next prev parent reply other threads:[~2012-07-20 21:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 9:20 [U-Boot] [PATCH 1/2] powerpc: Stack Pointer must be 16 aligned Joakim Tjernlund
2012-07-20 9:20 ` [U-Boot] [PATCH 2/2] mpc85xx: Initial SP alignment is wrong Joakim Tjernlund
2012-07-20 21:11 ` Scott Wood
2012-07-21 15:06 ` Joakim Tjernlund
2012-07-23 9:52 ` Joakim Tjernlund
2012-07-23 16:52 ` Scott Wood
2012-07-23 17:11 ` Joakim Tjernlund
2012-07-23 17:28 ` Scott Wood
2012-07-23 21:02 ` Joakim Tjernlund
2012-07-20 21:12 ` Scott Wood [this message]
2012-07-21 15:10 ` [U-Boot] [PATCH 1/2] powerpc: Stack Pointer must be 16 aligned Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5009C9D1.70601@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.