All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Horky <jiri.horky@gmail.com>
To: Steve Dickson <SteveD@redhat.com>
Cc: linux-nfs@vger.kernel.org, "du@cesnet.cz" <du@cesnet.cz>
Subject: Re: idmapd client-side static mapping
Date: Sun, 22 Jul 2012 22:34:00 +0200	[thread overview]
Message-ID: <500C63B8.2030200@gmail.com> (raw)
In-Reply-To: <4FFEE612.8060406@RedHat.com>

Hi,

I sent the patch in the separated email and now I hope for the best :)

Some more notes: if one configures only the "Static" translation method 
nowadays, any translation of id to name does not occur (since it is not 
implemented), return code of the nfs4_uid_to_name() function will be 0 
which is set by init function in libnfsidmap.c:357 and you get empty 
string as the result which puzzles the client and completely freezes the 
system. It can be triggered by e.g. issuing "chown 1000 /nfs4mnt/testfile".
I think that more correct behavior would be to return -ENOENT if there 
are no plugins with a given translation function. This is not included 
in the patch sent.

By the way, is there a reason why the function like nfs4_name_to_uid or 
its "gid" partner does not return "nobody/nogroup" when it fails to do 
the translation? On my system, it is set to a random value 
(uninitialized int) in this case.

Jiri Horky





On 07/12/2012 04:58 PM, Steve Dickson wrote:
> On 07/12/2012 09:54 AM, Jiri Horky wrote:
>> Hi,
>>
>> man pages for idmapd.conf states possibility to use Static mapping. Looking at the source code of libnfsidmap v0.24, it is clear that static mappings are only valid for server side (svcgssd) which the man page forgets to mention. Is there any specific reason why not to implement the static resolution functions on the client side as well?
> That is a good question... I always wonders this myself....
>
>> I would send a patch if there is a change it will be accepted.
> There is only one way to find out! ;-)
>
> steved.

      reply	other threads:[~2012-07-22 20:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-12 13:54 idmapd client-side static mapping Jiri Horky
2012-07-12 14:58 ` Steve Dickson
2012-07-22 20:34   ` Jiri Horky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=500C63B8.2030200@gmail.com \
    --to=jiri.horky@gmail.com \
    --cc=SteveD@redhat.com \
    --cc=du@cesnet.cz \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.