Re: [PATCH] mmc: dw-mmc: fixed secstion mismatch in reference

[Jaehoon Chung <jh80.chung@samsung.com>]

Hi Seungwon,

On 07/20/2012 08:36 PM, Seungwon Jeon wrote:
> Hi Jaehoon,
> 
> July 20, 2012, Jaehoon Chung <jh80.chung@samsung.com>
>> Fixed the below message.
>>
>> WARNING: drivers/mmc/host/built-in.o(.text+0x5ee8): Section mismatch in reference from the function
>> dw_mci_probe() to the function .init.text:dw_mci_init_slot()
>> The function dw_mci_probe() references
>> the function __init dw_mci_init_slot().
>> This is often because dw_mci_probe lacks a __init
>> annotation or the annotation of dw_mci_init_slot is wrong
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>>  drivers/mmc/host/dw_mmc.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
>> index 72dc3cd..7955eba 100644
>> --- a/drivers/mmc/host/dw_mmc.c
>> +++ b/drivers/mmc/host/dw_mmc.c
>> @@ -1760,7 +1760,7 @@ static void dw_mci_work_routine_card(struct work_struct *work)
>>  	}
>>  }
>>
>> -static int __init dw_mci_init_slot(struct dw_mci *host, unsigned int id)
>> +static int dw_mci_init_slot(struct dw_mci *host, unsigned int id)
>>  {
>>  	struct mmc_host *mmc;
>>  	struct dw_mci_slot *slot;
> 
> 
> __init macro isn't required?
> If so, how about adding __init macros to dw_mci_probe and dw_mci_pltfm_probe?
As you're mentioned, I think right that add __init macro to dw_mci_pltfm_probe.
but dw_mci_probe? i didn't think so...

Best Regards,
Jaehoon Chung
> 
> Best regards,
> Seungwon Jeon
>> --
>> 1.7.4.1
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
>