From: Christoph Egger <Christoph.Egger@amd.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH 4/9] build: include Tools.mk first in tools/Rules.mk
Date: Mon, 23 Jul 2012 14:19:47 +0200 [thread overview]
Message-ID: <500D4163.9060308@amd.com> (raw)
In-Reply-To: <1343043287.5797.1.camel@zakaz.uk.xensource.com>
On 07/23/12 13:34, Ian Campbell wrote:
> On Wed, 2012-07-11 at 11:23 +0100, Roger Pau Monne wrote:
>> Tools.mk should be included first, or PREFIX is not honoured in the
>> other conf/ files that define the paths of several tools.
>
> Isn't it a bug for anything which is included/defined via
> $(XEN_ROOT)/Config.mk to depend on the contents of
> $(XEN_ROOT)/config/Tools.mk since for anything non-tools Tools.mk would
> never be included at all?
When you specify --prefix to configure then this has no effect
w/o this patch.
Christoph
>>
>> Signed-off-by: Roger Pau Monne <roger.pau@citrix.com>
>> ---
>> tools/Rules.mk | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/tools/Rules.mk b/tools/Rules.mk
>> index 1e928b7..2dd8ed3 100644
>> --- a/tools/Rules.mk
>> +++ b/tools/Rules.mk
>> @@ -3,8 +3,8 @@
>> # `all' is the default target
>> all:
>>
>> -include $(XEN_ROOT)/Config.mk
>> -include $(XEN_ROOT)/config/Tools.mk
>> +include $(XEN_ROOT)/Config.mk
>>
>> export _INSTALL := $(INSTALL)
>> INSTALL = $(XEN_ROOT)/tools/cross-install
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2012-07-23 12:19 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 10:23 [PATCH 0/9] NetBSD: minor fixes and hotplug execution Roger Pau Monne
2012-07-11 10:23 ` [PATCH 1/9] xenstore: don't print an error when gntdev cannot be opened Roger Pau Monne
2012-07-23 11:42 ` Ian Campbell
2012-07-11 10:23 ` [PATCH 2/9] tools/build: fix pygrub linking Roger Pau Monne
2012-07-11 11:00 ` Christoph Egger
2012-07-12 16:30 ` Roger Pau Monne
2012-07-17 16:22 ` Ian Jackson
2012-07-17 16:34 ` Roger Pau Monne
2012-07-17 18:17 ` Ian Jackson
2012-07-18 8:26 ` Roger Pau Monne
2012-07-18 10:48 ` Ian Jackson
2012-07-18 13:55 ` Roger Pau Monne
2012-07-19 14:48 ` Ian Jackson
2012-07-19 15:00 ` Roger Pau Monne
2012-07-19 15:03 ` Ian Jackson
2012-07-11 10:23 ` [PATCH 3/9] pygrub: don't leave fds open Roger Pau Monne
2012-07-11 11:02 ` Christoph Egger
2012-07-17 16:01 ` Ian Jackson
2012-07-11 10:23 ` [PATCH 4/9] build: include Tools.mk first in tools/Rules.mk Roger Pau Monne
2012-07-11 11:52 ` Christoph Egger
2012-07-23 11:34 ` Ian Campbell
2012-07-23 12:19 ` Christoph Egger [this message]
2012-07-25 9:32 ` Roger Pau Monne
2012-07-25 10:39 ` Ian Campbell
2012-07-25 10:56 ` Roger Pau Monne
2012-07-25 16:43 ` Ian Campbell
2012-07-11 10:23 ` [PATCH 5/9] libxl: react correctly to POLLHUP Roger Pau Monne
2012-07-17 16:01 ` Ian Jackson
2012-07-11 10:23 ` [PATCH 6/9] libxl: check backend state before setting it to "closing" Roger Pau Monne
2012-07-17 16:05 ` Ian Jackson
2012-07-11 10:23 ` [PATCH 7/9] hotplug/NetBSD: check type of file to attach from params Roger Pau Monne
2012-07-11 11:54 ` Christoph Egger
2012-07-17 16:06 ` Ian Jackson
2012-07-17 16:35 ` Roger Pau Monne
2012-07-11 10:23 ` [PATCH 8/9] libxl: call hotplug scripts from xl for NetBSD Roger Pau Monne
2012-07-17 16:07 ` Ian Jackson
2012-07-11 10:23 ` [PATCH 9/9] init/NetBSD: move xenbackendd to xend init script Roger Pau Monne
2012-07-11 12:02 ` Christoph Egger
2012-07-17 16:08 ` Ian Jackson
2012-07-17 16:23 ` Roger Pau Monne
2012-07-18 9:04 ` Christoph Egger
2012-07-18 9:43 ` Roger Pau Monne
2012-07-18 9:46 ` Christoph Egger
2012-07-18 9:46 ` Roger Pau Monne
2012-07-18 10:50 ` Ian Jackson
2012-07-18 11:02 ` Roger Pau Monne
2012-07-18 9:02 ` Christoph Egger
2012-07-23 12:20 ` [PATCH 0/9] NetBSD: minor fixes and hotplug execution Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500D4163.9060308@amd.com \
--to=christoph.egger@amd.com \
--cc=Ian.Campbell@citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.