From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data Date: Mon, 23 Jul 2012 14:48:20 +0100 Message-ID: <500D5624.4010505@linaro.org> References: <1342766789-28148-1-git-send-email-anilkumar@ti.com> <1342766789-28148-2-git-send-email-anilkumar@ti.com> <20120720095935.GQ4495@opensource.wolfsonmicro.com> <331ABD5ECB02734CA317220B2BBEABC13E9FA91E@DBDE01.ent.ti.com> <20120720113806.GW4495@opensource.wolfsonmicro.com> <331ABD5ECB02734CA317220B2BBEABC13EA01F1E@DBDE01.ent.ti.com> <20120723133400.GU4435@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20120723133400.GU4435@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Mark Brown Cc: "tony@atomide.com" , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "AnilKumar, Chimata" List-Id: linux-omap@vger.kernel.org T24gMjMvMDcvMTIgMTQ6MzQsIE1hcmsgQnJvd24gd3JvdGU6Cj4gT24gTW9uLCBKdWwgMjMsIDIw MTIgYXQgMDE6MjM6NTBQTSArMDAwMCwgQW5pbEt1bWFyLCBDaGltYXRhIHdyb3RlOgo+Cj4+IEJ5 IHRoZSB3YXksIGlmIHdlIGxvb2sgYXQgYWxsIHRoZSByZWd1bGF0b3IgYWRkZWQgKERUIHN1cHBv cnRlZCkgdGlsbCBub3cgaGF2ZQo+PiB0aGUgc2ltaWxhciBwcm9ibGVtLgo+Cj4+IGFyY2gvYXJt L2Jvb3QvZHRzL2lteDZxLmR0c2kKPgo+IFRoaXMgaXMgZmluZSAtIHRoZSBTb0MgY29udGFpbnMg aW50ZWdyYXRlZCByZWd1bGF0b3JzIHdoaWNoIHN1cHBseSBvdGhlcgo+IGJpdHMgb2YgdGhlIFNv YyBzbyB3ZSBjYW4gYmUgY29uZmlkZW50IHRoYXQgdGhlIGhvb2t1cCBpcyBnb29kIGp1c3QKPiBi YXNlZCBvbiB0aGUgc2lsaWNvbi4KPgo+PiBhcmNoL2FybS9ib290L2R0cy90d2w0MDMwLmR0c2kK Pj4gYXJjaC9hcm0vYm9vdC9kdHMvdHdsNjAzMC5kdHNpCj4KPiBUaGVzZSBhcHBlYXIgdG8gaGF2 ZSBzaW1pbGFyIGlzc3VlcyBhbmQgc2hvdWxkIGJlIGZpeGVkLCBhdCBsZWFzdCBhcyBmYXIKPiBh cyB0aGUgdm9sdGFnZSByYW5nZXMgZ28uCj4KPj4gYXJjaC9hcm0vYm9vdC9kdHMvZGI4NTAwLmR0 c2kKPgo+IEknbSBub3QgYWN0dWFsbHkgc2VlaW5nIGFueXRoaW5nIHRlcnJpYmx5IHByb2JsZW1h dGljIGhlcmUsIHRob3VnaCB0aGUKPiByZWd1bGF0b3ItbmFtZSBwcm9wZXJ0aWVzIHNob3VsZCBy ZWFsbHkgYmUgcmVtb3ZlZCBhcyB0aGV5J3JlIGZhaXJseQo+IHVzZWxlc3MgYW5kIHNlZW0gdG8g YmUgbWlzc2luZyB0aGUgcG9pbnQgb2YgaGF2aW5nIHRoZSBwcm9wZXJ0eS4KCkkndmUgbWlzc2Vk IHRoZSBjb250ZXh0IG9mIHRoZSB0aHJlYWQsIHNvIGNhbid0IGNvbW1lbnQsIGJ1dCBJJ20gaGFw cHkgCnRvIHJlbW92ZSB0aGUgcmVndWxhdG9yLW5hbWUgcHJvcGVydGllcyBmcm9tIGRiODUwMC5k dHMuIEFkZGluZyB0byBteSBUT0RPLgoKLS0gCkxlZSBKb25lcwpMaW5hcm8gU1QtRXJpY3Nzb24g TGFuZGluZyBUZWFtIExlYWQKTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9y IEFSTSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Mon, 23 Jul 2012 14:48:20 +0100 Subject: [PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data In-Reply-To: <20120723133400.GU4435@opensource.wolfsonmicro.com> References: <1342766789-28148-1-git-send-email-anilkumar@ti.com> <1342766789-28148-2-git-send-email-anilkumar@ti.com> <20120720095935.GQ4495@opensource.wolfsonmicro.com> <331ABD5ECB02734CA317220B2BBEABC13E9FA91E@DBDE01.ent.ti.com> <20120720113806.GW4495@opensource.wolfsonmicro.com> <331ABD5ECB02734CA317220B2BBEABC13EA01F1E@DBDE01.ent.ti.com> <20120723133400.GU4435@opensource.wolfsonmicro.com> Message-ID: <500D5624.4010505@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 23/07/12 14:34, Mark Brown wrote: > On Mon, Jul 23, 2012 at 01:23:50PM +0000, AnilKumar, Chimata wrote: > >> By the way, if we look at all the regulator added (DT supported) till now have >> the similar problem. > >> arch/arm/boot/dts/imx6q.dtsi > > This is fine - the SoC contains integrated regulators which supply other > bits of the Soc so we can be confident that the hookup is good just > based on the silicon. > >> arch/arm/boot/dts/twl4030.dtsi >> arch/arm/boot/dts/twl6030.dtsi > > These appear to have similar issues and should be fixed, at least as far > as the voltage ranges go. > >> arch/arm/boot/dts/db8500.dtsi > > I'm not actually seeing anything terribly problematic here, though the > regulator-name properties should really be removed as they're fairly > useless and seem to be missing the point of having the property. I've missed the context of the thread, so can't comment, but I'm happy to remove the regulator-name properties from db8500.dts. Adding to my TODO. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog