From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Mon, 23 Jul 2012 17:59:21 +0000 Subject: Re: [PATCH 5/7] drivers/iommu/tegra-smmu.c: remove invalid reference to list iterator variable Message-Id: <500D90F9.7030909@wwwdotorg.org> List-Id: References: <1341747464-1772-1-git-send-email-Julia.Lawall@lip6.fr> <1341747464-1772-6-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1341747464-1772-6-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On 07/08/2012 05:37 AM, Julia Lawall wrote: > From: Julia Lawall Julia, It looks like this patch hasn't seen any replies since you didn't CC the maintainers of this code. I've CC'd them now. > If list_for_each_entry, etc complete a traversal of the list, the iterator > variable ends up pointing to an address at an offset from the list head, > and not a meaningful structure. Thus this value should not be used after > the end of the iterator. Replace c->dev by dev, which is the value that > c->dev has been compared to. > > This problem was found using Coccinelle (http://coccinelle.lip6.fr/). > > Signed-off-by: Julia Lawall Acked-by: Stephen Warren From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 5/7] drivers/iommu/tegra-smmu.c: remove invalid reference to list iterator variable Date: Mon, 23 Jul 2012 11:59:21 -0600 Message-ID: <500D90F9.7030909@wwwdotorg.org> References: <1341747464-1772-1-git-send-email-Julia.Lawall@lip6.fr> <1341747464-1772-6-git-send-email-Julia.Lawall@lip6.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1341747464-1772-6-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Julia Lawall Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: iommu@lists.linux-foundation.org On 07/08/2012 05:37 AM, Julia Lawall wrote: > From: Julia Lawall Julia, It looks like this patch hasn't seen any replies since you didn't CC the maintainers of this code. I've CC'd them now. > If list_for_each_entry, etc complete a traversal of the list, the iterator > variable ends up pointing to an address at an offset from the list head, > and not a meaningful structure. Thus this value should not be used after > the end of the iterator. Replace c->dev by dev, which is the value that > c->dev has been compared to. > > This problem was found using Coccinelle (http://coccinelle.lip6.fr/). > > Signed-off-by: Julia Lawall Acked-by: Stephen Warren From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754553Ab2GWR72 (ORCPT ); Mon, 23 Jul 2012 13:59:28 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:46772 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753473Ab2GWR7Z (ORCPT ); Mon, 23 Jul 2012 13:59:25 -0400 Message-ID: <500D90F9.7030909@wwwdotorg.org> Date: Mon, 23 Jul 2012 11:59:21 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 To: Julia Lawall CC: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Joerg Roedel , Hiroshi Doyu , "iommu@lists.linux-foundation.org" Subject: Re: [PATCH 5/7] drivers/iommu/tegra-smmu.c: remove invalid reference to list iterator variable References: <1341747464-1772-1-git-send-email-Julia.Lawall@lip6.fr> <1341747464-1772-6-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1341747464-1772-6-git-send-email-Julia.Lawall@lip6.fr> X-Enigmail-Version: 1.4.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/08/2012 05:37 AM, Julia Lawall wrote: > From: Julia Lawall Julia, It looks like this patch hasn't seen any replies since you didn't CC the maintainers of this code. I've CC'd them now. > If list_for_each_entry, etc complete a traversal of the list, the iterator > variable ends up pointing to an address at an offset from the list head, > and not a meaningful structure. Thus this value should not be used after > the end of the iterator. Replace c->dev by dev, which is the value that > c->dev has been compared to. > > This problem was found using Coccinelle (http://coccinelle.lip6.fr/). > > Signed-off-by: Julia Lawall Acked-by: Stephen Warren