From: Timur Tabi <timur@freescale.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
Hu Mingkai-B21284 <B21284@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Xie Shaohui-B21989 <B21989@freescale.com>,
Chen Yuanquan-B41889 <B41889@freescale.com>
Subject: Re: [PATCH] powerpc/mm: add ZONE_NORMAL zone for 64 bit kernel
Date: Mon, 23 Jul 2012 18:15:39 -0500 [thread overview]
Message-ID: <500DDB1B.9030900@freescale.com> (raw)
In-Reply-To: <1343085145.2957.44.camel@pasglop>
Benjamin Herrenschmidt wrote:
> Sure, that's the right way to go, I meant bits of pieces of the
> infrastructure in between. Why diverge from other archs gratuituously
> here ?
Ok, I'm confused. Are you suggesting that drivers do this:
u64 fsl_dma_dmamask = DMA_BIT_MASK(36);
dev->dma_mask = &fsl_dma_dmamask;
v = dma_alloc_coherent(dev, ..., GFP_DMA32);
That is, set the DMA mask *and* set GFP_DMA32? That seems redundant.
I don't understand why a driver would set GFP_DMA32 if it has already set
the mask.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2012-07-23 23:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 12:21 [PATCH] powerpc/mm: add ZONE_NORMAL zone for 64 bit kernel Shaohui Xie
2012-07-23 6:06 ` Benjamin Herrenschmidt
2012-07-23 16:17 ` Scott Wood
2012-07-23 22:20 ` Benjamin Herrenschmidt
2012-07-23 23:08 ` Tabi Timur-B04825
2012-07-23 23:12 ` Benjamin Herrenschmidt
2012-07-23 23:15 ` Timur Tabi [this message]
2012-07-23 23:29 ` Benjamin Herrenschmidt
2012-07-23 23:30 ` Benjamin Herrenschmidt
2012-07-24 1:37 ` Scott Wood
2012-07-23 23:36 ` Timur Tabi
2012-07-24 3:08 ` Benjamin Herrenschmidt
2012-07-24 3:52 ` Tabi Timur-B04825
2012-07-24 3:59 ` Zang Roy-R61911
2012-07-24 4:04 ` Tabi Timur-B04825
2012-07-24 4:45 ` Benjamin Herrenschmidt
2012-07-24 8:01 ` Bhushan Bharat-R65777
2012-07-24 1:49 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500DDB1B.9030900@freescale.com \
--to=timur@freescale.com \
--cc=B07421@freescale.com \
--cc=B21284@freescale.com \
--cc=B21989@freescale.com \
--cc=B41889@freescale.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.