From: "Justin P. Mattock" <justinmattock@gmail.com>
To: "Ramirez Luna, Omar" <omar.ramirez@ti.com>
Cc: gregkh@linuxfoundation.org, vjaquez@igalia.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH NEXT]staging "tidspbridge" Fix typos.
Date: Mon, 23 Jul 2012 20:37:50 -0700 [thread overview]
Message-ID: <500E188E.2020805@gmail.com> (raw)
In-Reply-To: <CAB-zwWjCEprbEGJ5f3HoyHhZPTaMUramZk=YG=1b63U-pGymQA@mail.gmail.com>
On 07/23/2012 01:44 PM, Ramirez Luna, Omar wrote:
> Hi Justin,
>
> On Mon, Jul 23, 2012 at 8:49 AM, Justin P. Mattock
> <justinmattock@gmail.com> wrote:
>> diff --git a/drivers/staging/tidspbridge/core/tiomap3430.c b/drivers/staging/tidspbridge/core/tiomap3430.c
>> index f9609ce..2c82d5a 100644
>> --- a/drivers/staging/tidspbridge/core/tiomap3430.c
>> +++ b/drivers/staging/tidspbridge/core/tiomap3430.c
>> @@ -328,7 +328,7 @@ static int bridge_brd_read(struct bridge_dev_context *dev_ctxt,
>> ul_num_bytes, mem_type);
>> return status;
>> }
>> - /* copy the data from DSP memory, */
>> + /* copy the data from DSP memory, */
>
> I guess we can get rid of the comma (,) at the end of this sentence.
good catch!
>
> ...
>> diff --git a/drivers/staging/tidspbridge/include/dspbridge/proc.h b/drivers/staging/tidspbridge/include/dspbridge/proc.h
>> index a82380e..9cd5022 100644
>> --- a/drivers/staging/tidspbridge/include/dspbridge/proc.h
>> +++ b/drivers/staging/tidspbridge/include/dspbridge/proc.h
>> @@ -263,7 +263,7 @@ extern int proc_get_processor_id(void *proc, u32 * proc_id);
>> * Returns:
>> * 0 : Success.
>> * -EFAULT : Invalid processor handle.
>> - * -EPERM : General failure while retireving processor trace
>> + * -EPERM : General failure while retireing processor trace
>
> This was meant to be 'retrieving'.
>
> And given that this is focused on tidspbridge, could you change the
> patch subject? To: staging: tidspbridge: fix typos.
>
> Cheers,
>
> Omar
>
ah.. I see now.. comments can be tough to decipher sometimes with what
the writer is saying, helps to know what the code is doing.
cheers, resending the revised version, and Thank you for taking the time.
Justin P. Mattock
prev parent reply other threads:[~2012-07-24 3:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 13:49 [PATCH NEXT]staging "tidspbridge" Fix typos Justin P. Mattock
2012-07-23 20:44 ` Ramirez Luna, Omar
2012-07-24 3:37 ` Justin P. Mattock [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500E188E.2020805@gmail.com \
--to=justinmattock@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=omar.ramirez@ti.com \
--cc=vjaquez@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.