All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Vinod Koul <vinod.koul@linux.intel.com>
Cc: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
	Stephen Warren <swarren@nvidia.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] dma: tegra: enable/disable dma clock
Date: Tue, 24 Jul 2012 10:30:16 +0530	[thread overview]
Message-ID: <500E2BE0.7060602@nvidia.com> (raw)
In-Reply-To: <1343106498.1726.5974.camel@vkoul-udesk3>

On Tuesday 24 July 2012 10:38 AM, Vinod Koul wrote:
> On Fri, 2012-07-20 at 13:31 +0530, Laxman Dewangan wrote:
>> Enable the DMA clock when allocating channel and
>> disable clock when freeing channels.
>>
>> Signed-off-by: Laxman Dewangan<ldewangan@nvidia.com>
>> ---
>> +	clk_disable_unprepare(tdma->dma_clk);
> What if another channel is active, disabling clock can cause bad
> behavior. You should check here if all channels are idle and then
> disable, or is this handled by clock API?

Yes, clock driver keeps the reference count and so client driver need 
not to take care.

Thanks,
Laxman



  reply	other threads:[~2012-07-24  5:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-20  8:01 [PATCH V2] dma: tegra: enable/disable dma clock Laxman Dewangan
2012-07-24  5:08 ` Vinod Koul
2012-07-24  5:00   ` Laxman Dewangan [this message]
2012-07-27  8:12     ` Laxman Dewangan
2012-07-31  6:48       ` Vinod Koul
2012-07-31  7:12         ` Laxman Dewangan
2012-07-31 10:46 ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=500E2BE0.7060602@nvidia.com \
    --to=ldewangan@nvidia.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=swarren@nvidia.com \
    --cc=vinod.koul@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.