From: Stefano Lattarini <stefano.lattarini@gmail.com>
To: Jiang Xin <worldhello.net@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Git List" <git@vger.kernel.org>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Jonathan Nieder" <jrnieder@gmail.com>
Subject: Re: [PATCH v3 1/7] i18n: New keywords for xgettext extraction from sh
Date: Tue, 24 Jul 2012 11:38:02 +0200 [thread overview]
Message-ID: <500E6CFA.6030203@gmail.com> (raw)
In-Reply-To: <6fbf2661d428ca4c4227b418368716d903dfd3e3.1343112786.git.worldhello.net@gmail.com>
On 07/24/2012 08:59 AM, Jiang Xin wrote:
> Since we have additional shell wrappers (gettextln and eval_gettextln)
> for gettext, we need to take into account these wrappers when run
>
s/when run/when running/ or s/when we run/.
Sorry for not spotting that in my first review!
> 'make pot' to extract messages from shell scripts.
>
Regards,
Stefano
next prev parent reply other threads:[~2012-07-24 9:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 6:59 [PATCH v3 0/7] i18n for git-am, git-rebase and git-merge Jiang Xin
2012-07-24 6:59 ` [PATCH v3 1/7] i18n: New keywords for xgettext extraction from sh Jiang Xin
2012-07-24 9:38 ` Stefano Lattarini [this message]
2012-07-24 17:46 ` Jonathan Nieder
2012-07-24 6:59 ` [PATCH v3 2/7] i18n: rebase: mark strings for translation Jiang Xin
2012-07-24 9:43 ` Stefano Lattarini
2012-07-24 18:01 ` Jonathan Nieder
2012-07-24 18:57 ` Junio C Hamano
2012-07-24 22:49 ` Jiang Xin
2012-07-24 6:59 ` [PATCH v3 3/7] i18n: Rewrite gettext messages start with dash Jiang Xin
2012-07-24 9:44 ` Stefano Lattarini
2012-07-24 6:59 ` [PATCH v3 4/7] Remove obsolete LONG_USAGE which breaks xgettext Jiang Xin
2012-07-24 18:08 ` Jonathan Nieder
2012-07-24 19:07 ` Junio C Hamano
2012-07-24 6:59 ` [PATCH v3 5/7] i18n: am: mark more strings for translation Jiang Xin
2012-07-24 18:16 ` Jonathan Nieder
2012-07-24 20:43 ` Junio C Hamano
2012-07-25 6:38 ` Thomas Rast
2012-07-24 23:00 ` Jiang Xin
2012-07-24 6:59 ` [PATCH v3 6/7] Remove unused and bad gettext block from git-am Jiang Xin
2012-07-24 18:27 ` Jonathan Nieder
2012-07-24 20:40 ` Junio C Hamano
2012-07-24 21:16 ` Martin von Zweigbergk
2012-07-24 21:21 ` Junio C Hamano
2012-07-24 21:25 ` Jonathan Nieder
2012-07-24 22:18 ` Junio C Hamano
2012-07-24 6:59 ` [PATCH v3 7/7] i18n: merge-recursive: mark strings for translation Jiang Xin
2012-07-24 9:47 ` Stefano Lattarini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500E6CFA.6030203@gmail.com \
--to=stefano.lattarini@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.