All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: benoit.canet@gmail.com
Cc: stefanha@gmail.com, pbonzini@redhat.com,
	"Benoît Canet" <benoit@irqsave.net>,
	qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH V4 0/3] Block migration if any of the block device is busy
Date: Tue, 24 Jul 2012 11:52:46 +0200	[thread overview]
Message-ID: <500E706E.8030405@redhat.com> (raw)
In-Reply-To: <1343053380-12133-1-git-send-email-benoit@irqsave.net>

Am 23.07.2012 16:22, schrieb benoit.canet@gmail.com:
> From: Benoît Canet <benoit@irqsave.net>
> 
> This patchset is designed to avoid starting a live migration while any of
> the block device is busy.
> 
> Tested with the following sequence:
> 
> QEMU 1.1.50 monitor - type 'help' for more information
> (qemu) block_stream virtio0 1k
> (qemu) migrate tcp:localhost:4444
> migrate: Migration is blocked by streaming
> (qemu)  block_job_cancel virtio0
> (qemu)  migrate tcp:localhost:4444
> migrate: Connection can not be completed immediately
> (qemu) 
> => migration then succeed

Maybe I'm missing the obvious, but why? Migration will stop the
streaming if it isn't restarted explicitly on the destination, but I
think that's expected.

Also, there are migration blockers. Wouldn't it be better to use them
instead of adding more special-case code to migration.c?

Kevin

  parent reply	other threads:[~2012-07-24  9:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-23 14:22 [Qemu-devel] [PATCH V4 0/3] Block migration if any of the block device is busy benoit.canet
2012-07-23 14:22 ` [Qemu-devel] [PATCH V4 1/3] block: Add bdrv_are_busy() benoit.canet
2012-07-23 17:15   ` Luiz Capitulino
2012-07-24 10:10     ` Benoît Canet
2012-07-24 12:55       ` Luiz Capitulino
2012-07-24 13:29         ` Kevin Wolf
2012-07-24 14:37           ` Benoît Canet
2012-07-24 14:42             ` Kevin Wolf
2012-07-23 14:22 ` [Qemu-devel] [PATCH V4 2/3] qerror: Add error telling that block dev usage prevents migration benoit.canet
2012-07-23 17:09   ` Luiz Capitulino
2012-07-23 14:23 ` [Qemu-devel] [PATCH V4 3/3] migration: block migration when any of the block device is busy benoit.canet
2012-07-23 14:58 ` [Qemu-devel] [PATCH V4 0/3] Block migration if " Stefan Hajnoczi
2012-07-24  9:52 ` Kevin Wolf [this message]
2012-07-24 10:04   ` Stefan Hajnoczi
2012-07-24 10:19     ` Kevin Wolf
2012-07-24 11:12       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=500E706E.8030405@redhat.com \
    --to=kwolf@redhat.com \
    --cc=benoit.canet@gmail.com \
    --cc=benoit@irqsave.net \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.