From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Stdfx-0003bI-Bu for qemu-devel@nongnu.org; Tue, 24 Jul 2012 07:53:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Stdft-000206-BF for qemu-devel@nongnu.org; Tue, 24 Jul 2012 07:53:17 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34343 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Stdft-000202-4W for qemu-devel@nongnu.org; Tue, 24 Jul 2012 07:53:13 -0400 Message-ID: <500E8CA5.7010008@suse.de> Date: Tue, 24 Jul 2012 13:53:09 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1342017621-12650-1-git-send-email-pbonzini@redhat.com> <1342017621-12650-3-git-send-email-pbonzini@redhat.com> <500E8935.3010603@suse.de> <500E8A44.5070705@redhat.com> In-Reply-To: <500E8A44.5070705@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/2] build: get dependency file directories from object file names List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: jan.kiszka@siemens.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, avi@redhat.com Am 24.07.2012 13:43, schrieb Paolo Bonzini: > Il 24/07/2012 13:38, Andreas F=E4rber ha scritto: >>>> +$(foreach var,$(nested-vars), $(eval \ >>>> + -include $(addsuffix *.d, $(sort $(dir $($(var))))))) >>>> endef >>>> >> Are you sure? Dependencies are not guaranteed to be in one of the >> unnested variables, thought we ran into some issues earlier... In >> particular I'm thinking of tcg/*.d and of *.d in .user, .target, those >> that are actually recursed into. >=20 > obj-y is a nested variable: >=20 > nested-vars +=3D obj-y >=20 > # This resolves all nested paths, so it must come last > include $(SRC_PATH)/Makefile.objs >=20 > $(dir $(obj-y)) contains tcg/ and from there you get tcg/*.d. >=20 > The only makefile that doesn't use the nesting mechanism is tests/Makef= ile. I think you misunderstood: My worry is qemu-something: $(obj-y) foo bar baz obj-y and friends are handled, foo, bar, baz are not. If you checked all those cases, fine with me. :) Otherwise the new unnesting rule is fine, but not all "*.d" inclusions could be deleted. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg