From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Stdw2-0004Hs-PX for qemu-devel@nongnu.org; Tue, 24 Jul 2012 08:09:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Stdvy-0007Ne-OP for qemu-devel@nongnu.org; Tue, 24 Jul 2012 08:09:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20847) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Stdvy-0007NX-GM for qemu-devel@nongnu.org; Tue, 24 Jul 2012 08:09:50 -0400 Message-ID: <500E906F.5040709@redhat.com> Date: Tue, 24 Jul 2012 14:09:19 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1343048885-1701-1-git-send-email-coreyb@linux.vnet.ibm.com> In-Reply-To: <1343048885-1701-1-git-send-email-coreyb@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 0/6] file descriptor passing using fd sets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corey Bryant Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, libvir-list@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, eblake@redhat.com Am 23.07.2012 15:07, schrieb Corey Bryant: > Corey Bryant (6): > qemu-char: Add MSG_CMSG_CLOEXEC flag to recvmsg > qapi: Introduce add-fd, remove-fd, query-fdsets > monitor: Clean up fd sets on monitor disconnect > block: Convert open calls to qemu_open > block: Convert close calls to qemu_close > block: Enable qemu_open/close to work with fd sets > > block/raw-posix.c | 42 ++++----- > block/raw-win32.c | 6 +- > block/vdi.c | 5 +- > block/vmdk.c | 25 +++--- > block/vpc.c | 4 +- > block/vvfat.c | 16 ++-- > cutils.c | 5 ++ > monitor.c | 244 ++++++++++++++++++++++++++++++++++++++++++++++++++++- > monitor.h | 4 + > osdep.c | 141 +++++++++++++++++++++++++++++++ > qapi-schema.json | 97 +++++++++++++++++++++ > qemu-char.c | 10 ++- > qemu-common.h | 2 + > qemu-tool.c | 12 +++ > qmp-commands.hx | 121 ++++++++++++++++++++++++++ > savevm.c | 4 +- > 16 files changed, 684 insertions(+), 54 deletions(-) Apart from the points I commented on in patch 6, and what Eric and you found, this looks good to me. Kevin