From: Jeff Law <law@redhat.com>
To: Josh Boyer <jwboyer@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] posix_types.h: make __NFDBITS match glibc definition
Date: Tue, 24 Jul 2012 13:19:29 -0600 [thread overview]
Message-ID: <500EF541.50009@redhat.com> (raw)
In-Reply-To: <20120724182409.GB10534@zod.bos.redhat.com>
On 07/24/12 12:24, Josh Boyer wrote:
> On Tue, Jul 24, 2012 at 11:20:11AM -0700, Linus Torvalds wrote:
>> On Tue, Jul 24, 2012 at 11:12 AM, Josh Boyer <jwboyer@redhat.com> wrote:
>>>
>>> +#define __NFDBITS (8 * (int) sizeof(long int))
>>
>> I don't know if the type change is needed, but who the hell uses "long int"?
>
> Not strictly, no. I believe in my brief tests, just the int cast was
> sufficient. I can respin if you'd like. I probably need to anyway to
> CC stable on this.
All that's strictly necessary is that cast to (int). That avoids the
problem.
Jeff
next prev parent reply other threads:[~2012-07-24 19:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 18:12 [PATCH] posix_types.h: make __NFDBITS match glibc definition Josh Boyer
2012-07-24 18:20 ` Linus Torvalds
2012-07-24 18:24 ` Josh Boyer
2012-07-24 18:32 ` [PATCH v2] posix_types.h: make __NFDBITS compatible with " Josh Boyer
2012-07-24 18:46 ` Linus Torvalds
2012-07-24 19:03 ` Josh Boyer
2012-07-24 19:09 ` Linus Torvalds
2012-07-24 19:15 ` Jeff Law
2012-07-24 19:24 ` Linus Torvalds
2012-07-24 19:26 ` Jeff Law
2012-07-24 19:43 ` Josh Boyer
2012-07-24 19:55 ` Linus Torvalds
2012-07-24 20:10 ` Josh Boyer
2012-07-24 20:13 ` Linus Torvalds
2012-07-24 20:02 ` Andreas Schwab
2012-07-24 19:43 ` Linus Torvalds
2012-07-24 20:01 ` Jeff Law
2012-07-24 19:19 ` Jeff Law [this message]
2012-07-24 19:37 ` [PATCH] posix_types.h: make __NFDBITS match " Linus Torvalds
2012-07-24 19:39 ` Linus Torvalds
2012-07-24 19:41 ` Josh Boyer
2012-07-24 19:59 ` Linus Torvalds
2012-07-24 20:11 ` Linus Torvalds
2012-07-24 20:52 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500EF541.50009@redhat.com \
--to=law@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jwboyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.