Re: + ppc-e500_tlb-memset-clears-nothing.patch added to -mm tree

[Avi Kivity <avi@redhat.com>]

On 07/25/2012 12:00 AM, akpm@linux-foundation.org wrote:
> The patch titled
>      Subject: ppc: e500_tlb memset clears nothing
> has been added to the -mm tree.  Its filename is
>      ppc-e500_tlb-memset-clears-nothing.patch
> 

The kvm tree is maintained.  Alex, please pick up this patch; I guess
it's 3.6 material.


> 
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
> 
> The -mm tree is included into linux-next and is updated
> there every 3-4 working days
> 
> ------------------------------------------------------
> From: Alan Cox <alan@linux.intel.com>
> Subject: ppc: e500_tlb memset clears nothing
> 
> Put the parameters the right way around
> 
> Addresses https://bugzilla.kernel.org/show_bug.cgi?id=44031
> 
> Reported-by: David Binderman <dcb314@hotmail.com>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> Cc: Avi Kivity <avi@redhat.com>
> Cc: Marcelo Tosatti <mtosatti@redhat.com>
> Cc: Alexander Graf <agraf@suse.de>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  arch/powerpc/kvm/e500_tlb.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff -puN arch/powerpc/kvm/e500_tlb.c~ppc-e500_tlb-memset-clears-nothing arch/powerpc/kvm/e500_tlb.c
> --- a/arch/powerpc/kvm/e500_tlb.c~ppc-e500_tlb-memset-clears-nothing
> +++ a/arch/powerpc/kvm/e500_tlb.c
> @@ -322,11 +322,11 @@ static inline void kvmppc_e500_ref_relea
>  static void clear_tlb1_bitmap(struct kvmppc_vcpu_e500 *vcpu_e500)
>  {
>  	if (vcpu_e500->g2h_tlb1_map)
> -		memset(vcpu_e500->g2h_tlb1_map,
> -		       sizeof(u64) * vcpu_e500->gtlb_params[1].entries, 0);
> +		memset(vcpu_e500->g2h_tlb1_map, 0,
> +		       sizeof(u64) * vcpu_e500->gtlb_params[1].entries);
>  	if (vcpu_e500->h2g_tlb1_rmap)
> -		memset(vcpu_e500->h2g_tlb1_rmap,
> -		       sizeof(unsigned int) * host_tlb_params[1].entries, 0);
> +		memset(vcpu_e500->h2g_tlb1_rmap, 0,
> +		       sizeof(unsigned int) * host_tlb_params[1].entries);
>  }
>  
>  static void clear_tlb_privs(struct kvmppc_vcpu_e500 *vcpu_e500)
> _
> Subject: Subject: ppc: e500_tlb memset clears nothing
> 

-- 
error compiling committee.c: too many arguments to function