From: Stefano Lattarini <stefano.lattarini@gmail.com>
To: Jiang Xin <worldhello.net@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Git List" <git@vger.kernel.org>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Jonathan Nieder" <jrnieder@gmail.com>,
"Martin von Zweigbergk" <martin.von.zweigbergk@gmail.com>
Subject: Re: [PATCH v4 5/7] i18n: am: mark more strings for translation
Date: Wed, 25 Jul 2012 11:59:20 +0200 [thread overview]
Message-ID: <500FC378.5090706@gmail.com> (raw)
In-Reply-To: <1493bd09efd0ba6e1d56500305d989047da245ec.1343188013.git.worldhello.net@gmail.com>
Sorry to be so nit-picky, but ...
On 07/25/2012 05:53 AM, Jiang Xin wrote:
> Mark strings in 'git-am.sh' for translation. In the last chunk, I
> changed '$1' to '-b/--binary' for this reason:
>
> * First, if there is a variable in the l10n message, we could not use
> gettext. Because the variable will be expanded (evaluated) and will
> never match the entry in the po file.
>
> * Second, if there is a positional parameter ($1, $2,...) in the
> message, we could not use eval_gettext either. Because
> eval_gettext may be a wapper for gettext, and the positional
> parameter would loose it's original context.
>
... here you should s/it's/its/.
Regards,
Stefano
next prev parent reply other threads:[~2012-07-25 9:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 3:53 [PATCH v4 0/7] i18n for git-am, git-rebase and git-merge Jiang Xin
2012-07-25 3:53 ` [PATCH v4 1/7] i18n: New keywords for xgettext extraction from sh Jiang Xin
2012-07-25 3:53 ` [PATCH v4 2/7] i18n: rebase: mark strings for translation Jiang Xin
2012-07-25 4:21 ` Jonathan Nieder
2012-07-25 7:32 ` Jiang Xin
2012-07-25 9:56 ` Jonathan Nieder
2012-07-25 3:53 ` [PATCH v4 3/7] i18n: Rewrite gettext messages start with dash Jiang Xin
2012-07-25 3:53 ` [PATCH v4 4/7] Remove obsolete LONG_USAGE which breaks xgettext Jiang Xin
2012-07-25 3:53 ` [PATCH v4 5/7] i18n: am: mark more strings for translation Jiang Xin
2012-07-25 4:26 ` Jonathan Nieder
2012-07-25 9:59 ` Stefano Lattarini [this message]
2012-07-25 11:01 ` Jiang Xin
2012-07-25 3:53 ` [PATCH v4 6/7] Remove dead code which contains bad gettext block Jiang Xin
2012-07-25 4:30 ` Jonathan Nieder
2012-07-25 3:53 ` [PATCH v4 7/7] i18n: merge-recursive: mark strings for translation Jiang Xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500FC378.5090706@gmail.com \
--to=stefano.lattarini@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=martin.von.zweigbergk@gmail.com \
--cc=pclouds@gmail.com \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.