From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59682)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1StybE-0004Yi-Tb
	for qemu-devel@nongnu.org; Wed, 25 Jul 2012 06:13:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1StybD-0005vR-DV
	for qemu-devel@nongnu.org; Wed, 25 Jul 2012 06:13:48 -0400
Received: from isrv.corpit.ru ([86.62.121.231]:49856)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1StybD-0005uY-5r
	for qemu-devel@nongnu.org; Wed, 25 Jul 2012 06:13:47 -0400
Message-ID: <500FC6D2.2080000@msgid.tls.msk.ru>
Date: Wed, 25 Jul 2012 14:13:38 +0400
From: Michael Tokarev <mjt@tls.msk.ru>
MIME-Version: 1.0
References: <20120706092054.32044.37307.malonedeb@wampee.canonical.com>
	<20120725082553.26838.91137.malone@chaenomeles.canonical.com>
In-Reply-To: <20120725082553.26838.91137.malone@chaenomeles.canonical.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Bug 1021649] Re: qemu 1.1.0 waits for a keypress
 at boot
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>

Stefano, Paul, can you take a look please?

https://bugs.launchpad.net/bugs/1021649

Thanks,

/mjt

On 25.07.2012 12:25, Michael Tokarev wrote:
> Jamie Heilman (the debian bug #680719 reporter) bisected this issue to
> this commit:
> 
> 7c7db75576bd5a31508208f153c5aada64b2c8df is the first bad commit
> commit 7c7db75576bd5a31508208f153c5aada64b2c8df
> Author: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Date:   Fri Apr 13 19:35:04 2012 +0100
> 
>     main_loop_wait: block indefinitely
>     
>     - remove qemu_calculate_timeout;
>     
>     - explicitly size timeout to uint32_t;
>     
>     - introduce slirp_update_timeout;
>     
>     - pass NULL as timeout argument to select in case timeout is the maximum
>     value;
>     
>     Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>     Acked-by: Paul Brook <paul@codesourcery.com>
>     Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>