All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: benoit.canet@gmail.com
Cc: "Benoît Canet" <benoit@irqsave.net>,
	stefanha@gmail.com, qemu-devel@nongnu.org,
	lcapitulino@redhat.com, pbonzini@redhat.com,
	stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH V2 3/3] hmp: show the backing file ancestors count
Date: Wed, 25 Jul 2012 12:59:00 +0200	[thread overview]
Message-ID: <500FD174.10204@redhat.com> (raw)
In-Reply-To: <1343203902-10524-4-git-send-email-benoit@irqsave.net>

Am 25.07.2012 10:11, schrieb benoit.canet@gmail.com:
> From: Benoît Canet <benoit@irqsave.net>
> 
> Signed-off-by: Benoit Canet <benoit@irqsave.net>
> ---
>  hmp.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hmp.c b/hmp.c
> index 6b72a64..19dcb65 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -227,6 +227,8 @@ void hmp_info_block(Monitor *mon)
>              if (info->value->inserted->has_backing_file) {
>                  monitor_printf(mon, " backing_file=");
>                  monitor_print_filename(mon, info->value->inserted->backing_file);
> +                monitor_printf(mon, " backing_file_ancestors_count=%" PRId64,
> +                    info->value->inserted->backing_file_ancestors_count);

This is not what a user interface looks like. Maybe something like "%d
backing files", and omit the message if there aren't any backing files.

Kevin

  reply	other threads:[~2012-07-25 10:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-25  8:11 [Qemu-devel] [PATCH V2 0/3] Show backing file ancestors count in HMP benoit.canet
2012-07-25  8:11 ` [Qemu-devel] [PATCH V2 1/3] block: create bdrv_get_backing_file_ancestors_count() benoit.canet
2012-07-25  8:11 ` [Qemu-devel] [PATCH V2 2/3] block: Use bdrv_get_backing_file_ancestors_count() benoit.canet
2012-07-25 10:57   ` Kevin Wolf
2012-07-25 11:15     ` Benoît Canet
2012-07-25 11:19       ` Kevin Wolf
2012-07-25 11:42         ` Benoît Canet
2012-07-25 12:03           ` Kevin Wolf
2012-07-25  8:11 ` [Qemu-devel] [PATCH V2 3/3] hmp: show the backing file ancestors count benoit.canet
2012-07-25 10:59   ` Kevin Wolf [this message]
     [not found]     ` <20120725111756.GC12455@irqsave.net>
2012-07-25 11:22       ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=500FD174.10204@redhat.com \
    --to=kwolf@redhat.com \
    --cc=benoit.canet@gmail.com \
    --cc=benoit@irqsave.net \
    --cc=lcapitulino@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.