From: Laszlo Ersek <lersek@redhat.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Zhi Yong Wu <wuzhy@cn.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v2 00/16] net: Move legacy QEMU VLAN code into net/hub.c
Date: Wed, 25 Jul 2012 15:19:36 +0200 [thread overview]
Message-ID: <500FF268.402@redhat.com> (raw)
In-Reply-To: <1343144119-18757-1-git-send-email-stefanha@linux.vnet.ibm.com>
On 07/24/12 17:35, Stefan Hajnoczi wrote:
> v2:
> * Change int64_t and unsigned int mess to int which is what VLAN IDs are today [Laszlo]
> * Remove bogus error_set() -> qerror_report() merge artifact [Laszlo]
> * Use net_hub_id_for_client(nc, NULL) == 0 instead of adding net_hub_port_peer_nc() [Laszlo]
> * Fix stray print_net_client(..., NetClientState *vc) argument name [Laszlo]
> * Consistently update vlan -> peer argument name [Laszlo]
> * Drop spurious closesocket(fd), probably merge conflict [Stefan]
I checked the interdiffs and my v1 comments.
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
next prev parent reply other threads:[~2012-07-25 13:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 15:35 [Qemu-devel] [PATCH v2 00/16] net: Move legacy QEMU VLAN code into net/hub.c Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 01/16] net: Add a hub net client Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 02/16] net: Use hubs for the vlan feature Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 03/16] net: Look up 'vlan' net clients using hubs Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 04/16] hub: Check that hubs are configured correctly Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 05/16] net: Drop vlan argument to qemu_new_net_client() Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 06/16] net: Convert qdev_prop_vlan to peer with hub Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 07/16] net: Remove vlan code from net.c Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 08/16] net: Remove VLANState Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 09/16] net: Rename non_vlan_clients to net_clients Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 10/16] net: Rename VLANClientState to NetClientState Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 11/16] net: Rename vc local variables to nc Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 12/16] net: Rename qemu_del_vlan_client() to qemu_del_net_client() Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 13/16] net: Make "info network" output more readable info Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 14/16] net: cleanup deliver/deliver_iov func pointers Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 15/16] net: determine if packets can be sent before net queue deliver packets Stefan Hajnoczi
2012-07-24 15:35 ` [Qemu-devel] [PATCH v2 16/16] hub: add the support for hub own flow control Stefan Hajnoczi
2012-07-25 1:06 ` [Qemu-devel] [PATCH v2 00/16] net: Move legacy QEMU VLAN code into net/hub.c Laszlo Ersek
2012-07-25 13:19 ` Laszlo Ersek [this message]
2012-07-30 15:49 ` Stefan Hajnoczi
2012-07-31 2:22 ` Zhi Yong Wu
2012-07-31 8:51 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500FF268.402@redhat.com \
--to=lersek@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
--cc=wuzhy@cn.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.