From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46119)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1Su3uf-000486-FB
	for qemu-devel@nongnu.org; Wed, 25 Jul 2012 11:54:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1Su3ue-0007o6-Dl
	for qemu-devel@nongnu.org; Wed, 25 Jul 2012 11:54:13 -0400
Received: from david.siemens.de ([192.35.17.14]:30511)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1Su3ue-0007nz-3p
	for qemu-devel@nongnu.org; Wed, 25 Jul 2012 11:54:12 -0400
Message-ID: <501016A2.2060702@siemens.com>
Date: Wed, 25 Jul 2012 17:54:10 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1343222672-25312-1-git-send-email-peter.maydell@linaro.org>
	<1343222672-25312-5-git-send-email-peter.maydell@linaro.org>
	<50101509.8060805@siemens.com>
	<CAFEAcA9Ry3N1rQc_7RSRnnyz6o+wjPbjMNZ43zqpY-c6nO=sCw@mail.gmail.com>
In-Reply-To: <CAFEAcA9Ry3N1rQc_7RSRnnyz6o+wjPbjMNZ43zqpY-c6nO=sCw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/6] kvm: Don't assume irqchip-in-kernel
	implies irqfds
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Alexander Graf <agraf@suse.de>, Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "patches@linaro.org" <patches@linaro.org>

On 2012-07-25 17:52, Peter Maydell wrote:
> On 25 July 2012 16:47, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> On 2012-07-25 15:24, Peter Maydell wrote:
>>> --- a/kvm-all.c
>>> +++ b/kvm-all.c
>>> @@ -101,6 +101,7 @@ struct KVMState
>>>  KVMState *kvm_state;
>>>  bool kvm_kernel_irqchip;
>>>  bool kvm_async_interrupt_injection;
>>> +bool kvm_irqfds_allowed;
>>
>> Why allowed vs enabled? You only have kvm_async_interrupt_injection as well.
> 
> I was trying to follow the existing pattern where the macro kvm_enabled()
> tests the variable kvm_allowed (though as you noticed I got it wrong for
> kvm_async_interrupt_injection: will fix that in v2.)
> 
> Having the two the same is valid C, it's just a style question whether
> having a variable foo and a macro foo() is considered confusing I guess.

I don't mind which way if they are consistent.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux