From: Jan Kiszka <jan.kiszka@siemens.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
patches@linaro.org, Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>,
Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 6/6] kvm: Add documentation comment for kvm_irqchip_in_kernel()
Date: Wed, 25 Jul 2012 18:47:02 +0200 [thread overview]
Message-ID: <50102306.3070702@siemens.com> (raw)
In-Reply-To: <50101356.4030305@suse.de>
On 2012-07-25 17:40, Andreas Färber wrote:
> Am 25.07.2012 15:24, schrieb Peter Maydell:
>> Now we've cleared out the architecture-independent uses of
>> kvm_irqchip_in_kernel(), we can add a doc comment describing
>> what it means.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>> kvm.h | 11 +++++++++++
>> 1 files changed, 11 insertions(+), 0 deletions(-)
>
> If you've cleared the arch-independent uses, can't it be moved out of
> the generic kvm.h? Otherwise if just the commit message is confusing me:
kvm_irqchip_in_kernel is still a generic service as it probes a generic
property - that just has arch-dependent detail semantics.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
prev parent reply other threads:[~2012-07-25 16:47 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 13:24 [Qemu-devel] [PATCH 0/6] split out uses of kvm_irqchip_in_kernel() Peter Maydell
2012-07-25 13:24 ` [Qemu-devel] [PATCH 1/6] kvm: Decouple 'interrupt injection is async' from 'kernel irqchip' Peter Maydell
2012-07-25 15:41 ` Jan Kiszka
2012-07-25 13:24 ` [Qemu-devel] [PATCH 2/6] kvm: Rename kvm_irqchip_set_irq to kvm_inject_async_irq Peter Maydell
2012-07-25 15:43 ` Jan Kiszka
2012-07-25 15:47 ` Avi Kivity
2012-07-25 15:53 ` Jan Kiszka
2012-07-25 15:55 ` Avi Kivity
2012-07-25 15:56 ` Peter Maydell
2012-07-25 15:58 ` Jan Kiszka
2012-07-25 16:09 ` Peter Maydell
2012-07-25 16:11 ` Jan Kiszka
2012-07-25 16:18 ` Peter Maydell
2012-07-25 16:24 ` Peter Maydell
2012-07-25 16:28 ` Jan Kiszka
2012-07-25 16:36 ` Avi Kivity
2012-07-25 16:41 ` Peter Maydell
2012-07-25 16:56 ` Jan Kiszka
2012-07-25 16:00 ` Avi Kivity
2012-07-25 15:55 ` Peter Maydell
2012-07-25 16:02 ` Avi Kivity
2012-07-25 13:24 ` [Qemu-devel] [PATCH 3/6] kvm: Move kvm_allows_irq0_override() to target-i386 Peter Maydell
2012-07-25 15:44 ` Jan Kiszka
2012-07-25 13:24 ` [Qemu-devel] [PATCH 4/6] kvm: Don't assume irqchip-in-kernel implies irqfds Peter Maydell
2012-07-25 15:47 ` Jan Kiszka
2012-07-25 15:52 ` Peter Maydell
2012-07-25 15:54 ` Jan Kiszka
2012-07-25 13:24 ` [Qemu-devel] [PATCH 5/6] kvm: Don't assume irqchip implies MSI routing via irqfds Peter Maydell
2012-07-25 15:49 ` Jan Kiszka
2012-07-25 13:24 ` [Qemu-devel] [PATCH 6/6] kvm: Add documentation comment for kvm_irqchip_in_kernel() Peter Maydell
2012-07-25 15:40 ` Andreas Färber
2012-07-25 16:47 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50102306.3070702@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=mtosatti@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.