From mboxrd@z Thu Jan 1 00:00:00 1970 From: sshtylyov@mvista.com (Sergei Shtylyov) Date: Wed, 25 Jul 2012 20:59:24 +0400 Subject: [PATCH v2 6/6] arm/dts: am33xx rtc node In-Reply-To: References: <500FD698.30906@mvista.com> Message-ID: <501025EC.6010600@mvista.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello. On 07/25/2012 06:09 PM, Mohammed, Afzal wrote: >>> + rtc at 44e3e000 { >> Address postfix in the node name without "reg" property? > As per [1], "The unit-address is included if the node describes > a device with an address". Which in this case it doesn't. > Here even though reg property is not present, as via hwmod > (see below) it is getting address, isn't it better to have it I think not. >>> + compatible = "ti,da830-rtc"; >>> + ti,hwmods = "rtc"; WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v2 6/6] arm/dts: am33xx rtc node Date: Wed, 25 Jul 2012 20:59:24 +0400 Message-ID: <501025EC.6010600@mvista.com> References: <500FD698.30906@mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-doc-owner@vger.kernel.org To: "Mohammed, Afzal" Cc: "Hilman, Kevin" , "a.zummo@towertech.it" , "davinci-linux-open-source@linux.davincidsp.com" , "linux@arm.linux.org.uk" , "rtc-linux@googlegroups.com" , "linux-doc@vger.kernel.org" , "tony@atomide.com" , "devicetree-discuss@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "rob.herring@calxeda.com" , "grant.likely@secretlab.ca" , "rob@landley.net" , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org Hello. On 07/25/2012 06:09 PM, Mohammed, Afzal wrote: >>> + rtc@44e3e000 { >> Address postfix in the node name without "reg" property? > As per [1], "The unit-address is included if the node describes > a device with an address". Which in this case it doesn't. > Here even though reg property is not present, as via hwmod > (see below) it is getting address, isn't it better to have it I think not. >>> + compatible = "ti,da830-rtc"; >>> + ti,hwmods = "rtc"; WBR, Sergei