From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37971) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SuEeN-0002Qb-AA for qemu-devel@nongnu.org; Wed, 25 Jul 2012 23:22:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SuEeM-0003QM-9S for qemu-devel@nongnu.org; Wed, 25 Jul 2012 23:22:07 -0400 Received: from e36.co.us.ibm.com ([32.97.110.154]:41488) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SuEeM-0003QD-3M for qemu-devel@nongnu.org; Wed, 25 Jul 2012 23:22:06 -0400 Received: from /spool/local by e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 25 Jul 2012 21:22:05 -0600 Received: from d03relay05.boulder.ibm.com (d03relay05.boulder.ibm.com [9.17.195.107]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id B368C19D8036 for ; Thu, 26 Jul 2012 03:21:54 +0000 (WET) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay05.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q6Q3LvaW090236 for ; Wed, 25 Jul 2012 21:21:57 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q6Q3LvWu027956 for ; Wed, 25 Jul 2012 21:21:57 -0600 Message-ID: <5010B7D3.6090309@linux.vnet.ibm.com> Date: Wed, 25 Jul 2012 23:21:55 -0400 From: Corey Bryant MIME-Version: 1.0 References: <1343048885-1701-1-git-send-email-coreyb@linux.vnet.ibm.com> <1343048885-1701-7-git-send-email-coreyb@linux.vnet.ibm.com> <500E901D.3080801@redhat.com> <500F6B04.4020508@linux.vnet.ibm.com> <500FACD6.700@redhat.com> <50104826.1040909@redhat.com> In-Reply-To: <50104826.1040909@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 6/6] block: Enable qemu_open/close to work with fd sets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Kevin Wolf , aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, libvir-list@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com On 07/25/2012 03:25 PM, Eric Blake wrote: > On 07/25/2012 02:22 AM, Kevin Wolf wrote: >>>> Hm, not a nice interface where qemu_close() needs the filename and >>>> (worse) could be given a wrong filename. Maybe it would be better to >>>> maintain a list of fd -> fdset mappings in qemu_open/close? >>>> >>> >>> I agree, I don't really like it either. >>> >>> We already have a list of fd -> fdset mappings (mon_fdset_fd_t -> >>> mon_fdset_t). Would it be too costly to loop through all the fdsets/fds >>> at the beginning of every qemu_close()? >> >> I don't think so. qemu_close() is not a fast path and happens almost >> never, and the list is short enough that searching it isn't a problem >> anyway. > > I agree - just do the loop to do the reverse lookup yourself, rather > than making qemu_close() have a different signature than close(). > Great, I'll do this then. -- Regards, Corey