From: Eric Blake <eblake@redhat.com>
To: benoit.canet@gmail.com
Cc: kwolf@redhat.com, "Benoît Canet" <benoit@irqsave.net>,
qemu-devel@nongnu.org, lcapitulino@redhat.com,
pbonzini@redhat.com, stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH V4 2/3] block: Use bdrv_get_backing_file_depth()
Date: Thu, 26 Jul 2012 06:30:23 -0600 [thread overview]
Message-ID: <5011385F.7000509@redhat.com> (raw)
In-Reply-To: <1343301366-18028-3-git-send-email-benoit@irqsave.net>
[-- Attachment #1: Type: text/plain, Size: 703 bytes --]
On 07/26/2012 05:16 AM, benoit.canet@gmail.com wrote:
> From: Benoît Canet <benoit@irqsave.net>
>
> Use the dedicated counting function in qmp_query_block in order to
> propagate the backing file depth to HMP.
>
> #
> +# @backing-file-depth: the count of ancestor's backing files (since: 1.2)
> +#
That still reads awkwardly; I had suggested completely ditching the word
'ancestor':
@backing_file_depth: number of files in the backing file chain (since: 1.2)
Also missing a counterpart patch to query-block in qmp-commands.hx to
list the new backing-file-depth field.
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
next prev parent reply other threads:[~2012-07-26 12:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 11:16 [Qemu-devel] [PATCH V4 0/3] Show backing file depth in HMP benoit.canet
2012-07-26 11:16 ` [Qemu-devel] [PATCH V4 1/3] block: create bdrv_get_backing_file_depth() benoit.canet
2012-07-26 11:16 ` [Qemu-devel] [PATCH V4 2/3] block: Use bdrv_get_backing_file_depth() benoit.canet
2012-07-26 12:30 ` Eric Blake [this message]
2012-07-26 11:16 ` [Qemu-devel] [PATCH V4 3/3] hmp: show the backing file depth benoit.canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5011385F.7000509@redhat.com \
--to=eblake@redhat.com \
--cc=benoit.canet@gmail.com \
--cc=benoit@irqsave.net \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.