From: Avi Kivity <avi@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
Kevin O'Connor <kevin@koconnor.net>,
seabios@seabios.org, qemu-devel@nongnu.org,
Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [SeaBIOS PATCH 2/2] allow CPUs to have non-contiguous Local APIC IDs (v2)
Date: Thu, 26 Jul 2012 17:55:09 +0300 [thread overview]
Message-ID: <50115A4D.2050303@redhat.com> (raw)
In-Reply-To: <20120726141653.GD27859@shell.eng.rdu.redhat.com>
On 07/26/2012 05:16 PM, Eduardo Habkost wrote:
>> >
>> > It's possible to replace the atomic read of CountCPUs with the bitmap weight
>> > calculation on the loop, but: is it really worth it?
>> >
>> Why not? This eliminates one more global state.
>
> Maybe we can simply make it stop being global and be used only by the
> smp.c initialization code?
>
> Even if the variable didn't exist yet, I think I would add it myself:
> it's simpler and more efficient to calculate the bitmap weight once,
> while filling the bitmap, than recalculating it every time on the
> while(cmos_smp_count) loop.
So you're spinning more efficiently?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-07-26 14:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 17:04 [Qemu-devel] [SeaBIOS PATCH 0/2] Allow non-contiguous APIC IDs (v2) Eduardo Habkost
2012-07-20 17:04 ` [Qemu-devel] [SeaBIOS PATCH 1/2] acpi: report real I/O APIC ID (0) on MADT table (v2) Eduardo Habkost
2012-07-23 12:16 ` Gleb Natapov
2012-07-24 17:20 ` Eduardo Habkost
2012-07-20 17:04 ` [Qemu-devel] [SeaBIOS PATCH 2/2] allow CPUs to have non-contiguous Local APIC IDs (v2) Eduardo Habkost
2012-07-23 12:20 ` Gleb Natapov
2012-07-25 18:42 ` Eduardo Habkost
2012-07-26 6:08 ` Gleb Natapov
2012-07-26 14:16 ` Eduardo Habkost
2012-07-26 14:55 ` Avi Kivity [this message]
2012-07-26 15:07 ` Eduardo Habkost
2012-07-26 16:08 ` Avi Kivity
2012-07-26 17:18 ` Eduardo Habkost
-- strict thread matches above, loose matches on Subject: below --
2012-07-25 18:45 [Qemu-devel] [SeaBIOS PATCH 0/2] Allow non-contiguous APIC IDs (v3) Eduardo Habkost
2012-07-25 18:45 ` [Qemu-devel] [SeaBIOS PATCH 2/2] allow CPUs to have non-contiguous Local APIC IDs (v2) Eduardo Habkost
2012-07-27 13:42 ` Laszlo Ersek
2012-07-27 13:43 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50115A4D.2050303@redhat.com \
--to=avi@redhat.com \
--cc=ehabkost@redhat.com \
--cc=gleb@redhat.com \
--cc=imammedo@redhat.com \
--cc=kevin@koconnor.net \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.