From: Rich Johnston <rjohnston@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/5] xfs: clean up xfs_inactive
Date: Thu, 26 Jul 2012 10:30:56 -0500 [thread overview]
Message-ID: <501162B0.10806@sgi.com> (raw)
In-Reply-To: <20120704151443.077344815@bombadil.infradead.org>
On 07/04/2012 10:13 AM, Christoph Hellwig wrote:
> The code to reserve log space and join the inode to the transaction is
> common for all cases, so don't duplicate it. Also remove the trivial
> xfs_inactive_symlink_local helper which can simply be opencode now.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> ---
> fs/xfs/xfs_vnodeops.c | 171 ++++++++++++--------------------------------------
> 1 file changed, 43 insertions(+), 128 deletions(-)
>
As stated this patch cleans up duplicate code and removed local helper
function. Looks good.
Reviewed-by: Rich Johnston <rjohnston@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-07-26 15:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 15:13 [PATCH 0/5] do not take the iolock in inode reclaim context Christoph Hellwig
2012-07-04 15:13 ` [PATCH 1/5] xfs: clean up xfs_inactive Christoph Hellwig
2012-07-26 15:30 ` Rich Johnston [this message]
2012-07-04 15:13 ` [PATCH 2/5] xfs: remove xfs_inactive_attrs Christoph Hellwig
2012-07-26 15:31 ` Rich Johnston
2012-07-04 15:13 ` [PATCH 3/5] xfs: do not take the iolock in xfs_inactive Christoph Hellwig
2012-07-26 15:31 ` Rich Johnston
2012-07-04 15:13 ` [PATCH 4/5] xfs: avoid the iolock in xfs_free_eofblocks for evicted inodes Christoph Hellwig
2012-07-26 15:31 ` Rich Johnston
2012-07-04 15:13 ` [PATCH 5/5] xfs: remove iolock lock classes Christoph Hellwig
2012-07-26 15:31 ` Rich Johnston
2012-07-06 0:05 ` [PATCH 0/5] do not take the iolock in inode reclaim context Sage Weil
[not found] ` <20120717071923.GD15473@infradead.org>
2012-07-17 15:46 ` Sage Weil
2012-07-17 17:27 ` Mark Tinguely
2012-07-26 15:30 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501162B0.10806@sgi.com \
--to=rjohnston@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.