All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] video: exynos_dp: check the only INTERLANE_ALIGN_DONE bit during Link Training
Date: Thu, 26 Jul 2012 17:22:51 +0000	[thread overview]
Message-ID: <50117CEB.2000503@gmx.de> (raw)
In-Reply-To: <000c01cd63f8$57550000$05ff0000$%han@samsung.com>

On 07/17/2012 08:44 AM, Jingoo Han wrote:
> The only INTERLANE_ALIGN_DONE bit should be checked for channel equalization
> during Link Training. Previously, the other bits such as LINK_STATUS_UPDATED
> were checked, and channel equalization procedure was repeated unnecessarily.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Applied.


Thanks,

Florian Tobias Schandinat

> ---
>  drivers/video/exynos/exynos_dp_core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/exynos/exynos_dp_core.c b/drivers/video/exynos/exynos_dp_core.c
> index 9db7b9f..6ca8043 100644
> --- a/drivers/video/exynos/exynos_dp_core.c
> +++ b/drivers/video/exynos/exynos_dp_core.c
> @@ -336,7 +336,7 @@ static int exynos_dp_channel_eq_ok(u8 link_status[6], int lane_count)
>  	u8 lane_status;
>  
>  	lane_align = link_status[2];
> -	if ((lane_align = DPCD_INTERLANE_ALIGN_DONE) = 0)
> +	if ((lane_align & DPCD_INTERLANE_ALIGN_DONE) = 0)
>  		return -EINVAL;
>  
>  	for (lane = 0; lane < lane_count; lane++) {


      reply	other threads:[~2012-07-26 17:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-17  8:44 [PATCH] video: exynos_dp: check the only INTERLANE_ALIGN_DONE bit during Link Training Jingoo Han
2012-07-26 17:22 ` Florian Tobias Schandinat [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50117CEB.2000503@gmx.de \
    --to=florianschandinat@gmx.de \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.