From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Cc: Chris Larson <clarson@kergoth.com>
Subject: Re: libxp: Change superfluous "+=" to simple "=" when using _append
Date: Thu, 26 Jul 2012 12:41:05 -0700 [thread overview]
Message-ID: <50119D51.6040602@linux.intel.com> (raw)
In-Reply-To: <CABcZAN=ovSNo96CmpA7jygJPTxD6Vp_QE80buXQxc4x4+NnnMg@mail.gmail.com>
On 07/26/2012 12:34 PM, Chris Larson wrote:
> On Thu, Jul 26, 2012 at 12:27 PM, Saul Wold <sgw@linux.intel.com> wrote:
>> On 07/23/2012 02:59 AM, Robert P. J. Day wrote:
>>>
>>>
>>> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>>>
>>> ---
>>>
>>> diff --git a/meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb
>>> b/meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb
>>> index 349dad1..dbd4609 100644
>>> --- a/meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb
>>> +++ b/meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb
>>> @@ -15,7 +15,7 @@ PE = "1"
>>>
>>> XORG_PN = "libXp"
>>>
>>> -CFLAGS_append += " -I ${S}/include/X11/XprintUtil -I
>>> ${S}/include/X11/extensions"
>>> +CFLAGS_append = " -I ${S}/include/X11/XprintUtil -I
>>> ${S}/include/X11/extensions"
>>>
>>> SRC_URI += "file://fix-cast-error.patch"
>>>
>>>
>> Merged into OE-Core
>
> A second janitorial-type task would be to find and remove unnecessary
> uses of _append entirely. This one for example, it's highly unlikely a
> += wouldn't do the job here. :)
Mind filing that as a Janitor bug?
Sau!
>
prev parent reply other threads:[~2012-07-26 19:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 9:59 libxp: Change superfluous "+=" to simple "=" when using _append Robert P. J. Day
2012-07-26 19:27 ` Saul Wold
2012-07-26 19:34 ` Chris Larson
2012-07-26 19:41 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50119D51.6040602@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=clarson@kergoth.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.