From mboxrd@z Thu Jan 1 00:00:00 1970 From: "zumeng.chen" Subject: Re: [PATCH] ARM: OMAP2+: ads7846 init: fix fault caused by freeing pen-down GPIO Date: Fri, 27 Jul 2012 06:40:26 +0800 Message-ID: <5011C75A.3080201@windriver.com> References: <1342048700-15040-1-git-send-email-khilman@ti.com> <500D494D.8020606@compulab.co.il> <500D4F2A.9090706@compulab.co.il> <87zk6mpbfa.fsf@ti.com> <5011B465.70605@windriver.com> <87ipdambgg.fsf@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail.windriver.com ([147.11.1.11]:37363 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752662Ab2GZWkm (ORCPT ); Thu, 26 Jul 2012 18:40:42 -0400 In-Reply-To: <87ipdambgg.fsf@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Kevin Hilman Cc: Igor Grinberg , Tony Lindgren , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Zumeng Chen On 2012=E5=B9=B407=E6=9C=8827=E6=97=A5 05:58, Kevin Hilman wrote: > "zumeng.chen" writes: > >> On 2012=E5=B9=B407=E6=9C=8827=E6=97=A5 03:30, Kevin Hilman wrote: >>> + Zumeng Chen >>> >>> Igor Grinberg writes: >>> >>>> Hi Kevin, >>>> >>>> I've just noticed that the patch has been modified by Arnd in a wa= y >>>> that of course will trigger GPIO use without being requested. >>>> I'm sorry, I was not available by that time Arnd changed the patch= =2E >>> Your right, your original patch isn't the problem. I found the roo= t >>> cause. >>> >>> The real problem is actually introduced by the merge of your patch = from >>> the arm-soc/cleanup branch, and this one from Zumeng Chen: commit >>> 16aced80f6 (ARM: OMAP3530evm: set pendown_state and debounce time f= or >>> ads7846) from the arm-soc/boards branch. >>> >>> However, looking closer at the one from Zumeng, that one is clearly= not >>> right. It unconditionally adds a *board-specific* ->get_pendown_st= ate >>> function to the pdata that is common to *all* boards. That's just = wrong >>> and has the side-effect of making ->get_pendown_state() wrong on ev= ery >>> board except the OMAP3EVM. Oops. >>> >>> So, IMO, in addition to $SUBJECT patch, in order to get the touchsc= reen >>> GPIO working on non OMAP3EVM boards, we also need something like th= is as >>> well. >> Definitely, thanks Kevin. >>> Igor, Zumeng, could you try this out on your boards anc confirm if = it's >>> working? I currently don't have a board setup with a touchscreen i= n my >>> board farm. >> Acked > Did you test this on your board? No, I just read/compiled it. > If so, could you respond with a > Tested-by tag? Thanks NP, Kevin, I'll test it after being office, and it's about ten o'clock this morning. Regards, Zumeng -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: zchen@windriver.com (zumeng.chen) Date: Fri, 27 Jul 2012 06:40:26 +0800 Subject: [PATCH] ARM: OMAP2+: ads7846 init: fix fault caused by freeing pen-down GPIO In-Reply-To: <87ipdambgg.fsf@ti.com> References: <1342048700-15040-1-git-send-email-khilman@ti.com> <500D494D.8020606@compulab.co.il> <500D4F2A.9090706@compulab.co.il> <87zk6mpbfa.fsf@ti.com> <5011B465.70605@windriver.com> <87ipdambgg.fsf@ti.com> Message-ID: <5011C75A.3080201@windriver.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2012?07?27? 05:58, Kevin Hilman wrote: > "zumeng.chen" writes: > >> On 2012?07?27? 03:30, Kevin Hilman wrote: >>> + Zumeng Chen >>> >>> Igor Grinberg writes: >>> >>>> Hi Kevin, >>>> >>>> I've just noticed that the patch has been modified by Arnd in a way >>>> that of course will trigger GPIO use without being requested. >>>> I'm sorry, I was not available by that time Arnd changed the patch. >>> Your right, your original patch isn't the problem. I found the root >>> cause. >>> >>> The real problem is actually introduced by the merge of your patch from >>> the arm-soc/cleanup branch, and this one from Zumeng Chen: commit >>> 16aced80f6 (ARM: OMAP3530evm: set pendown_state and debounce time for >>> ads7846) from the arm-soc/boards branch. >>> >>> However, looking closer at the one from Zumeng, that one is clearly not >>> right. It unconditionally adds a *board-specific* ->get_pendown_state >>> function to the pdata that is common to *all* boards. That's just wrong >>> and has the side-effect of making ->get_pendown_state() wrong on every >>> board except the OMAP3EVM. Oops. >>> >>> So, IMO, in addition to $SUBJECT patch, in order to get the touchscreen >>> GPIO working on non OMAP3EVM boards, we also need something like this as >>> well. >> Definitely, thanks Kevin. >>> Igor, Zumeng, could you try this out on your boards anc confirm if it's >>> working? I currently don't have a board setup with a touchscreen in my >>> board farm. >> Acked > Did you test this on your board? No, I just read/compiled it. > If so, could you respond with a > Tested-by tag? Thanks NP, Kevin, I'll test it after being office, and it's about ten o'clock this morning. Regards, Zumeng