Re: [PATCH v3] dbus: include dbus-launch in the main dbus package

[Radu Moisan <radu.moisan@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1351 bytes --]


On 07/27/2012 12:12 AM, Burton, Ross wrote:
> On 26 July 2012 14:17, Enrico Scholz <enrico.scholz@sigma-chemnitz.de> wrote:
>> Radu Moisan <radu.moisan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>> writes:
>>
>>> Followed suggestions from Bugz 2261:
>>>
>>> 1) remove the --with-x/--without-x configure arguments.
>> why? They are valid ./configure options and common when evaluating the
>> x11 distro-feature.  Selecting them explicitly makes the build more
>> predictable and detects configuration errors earlier.
>>
>> Sense of '--without-x' was disabling of x11 dependency, but not turning
>> off the x11-autolaunch feature.
> That's my fault, and I can't remember my reasoning.  Probably best to
> bring it back so the recipe is explicit.
>
> Radu, bring back this fragment, but correct the options
>
> EXTRA_OECONF_X = "${@base_contains('DISTRO_FEATURES', 'x11',
> '--enable-x11-autolaunch', '--disable-x11-autolaunch', d)}"
>
> Ross
>
I've looked into the configure script and found that autolaunch feature 
is depending on x11, in other words using --with-x/--without-x implies 
--enable-x11-autolaunch/--disable-x11-autolaunch, so I guess the initial 
EXTRA_OECONF_X line will do pretty much the same thing.

EXTRA_OECONF_X = "${@base_contains('DISTRO_FEATURES', 'x11', '--with-x', 
'--without-x', d)}"

Radu

[-- Attachment #2: Type: text/html, Size: 2533 bytes --]