From: Joe Jin <joe.jin@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH, v2] x86: fix off-by-one in nr_irqs_gsi calculation
Date: Fri, 27 Jul 2012 14:44:17 +0800 [thread overview]
Message-ID: <501238C1.4080709@oracle.com> (raw)
In-Reply-To: <501253AF0200007800090D7F@nat28.tlf.novell.com>
Acked!
Thanks Jan!
On 07/27/12 14:39, Jan Beulich wrote:
> highest_gsi() returns the last valid GSI, not a count.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> ---
> v2: Retain the (debatable) use of max() here.
>
> --- a/xen/arch/x86/io_apic.c
> +++ b/xen/arch/x86/io_apic.c
> @@ -2531,7 +2531,7 @@ void __init init_ioapic_mappings(void)
> }
> }
>
> - nr_irqs_gsi = max(nr_irqs_gsi, highest_gsi());
> + nr_irqs_gsi = max(nr_irqs_gsi, highest_gsi() + 1);
>
> if ( max_gsi_irqs == 0 )
> max_gsi_irqs = nr_irqs ? nr_irqs / 8 : PAGE_SIZE;
>
>
>
next prev parent reply other threads:[~2012-07-27 6:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 6:39 [PATCH, v2] x86: fix off-by-one in nr_irqs_gsi calculation Jan Beulich
2012-07-27 6:44 ` Joe Jin [this message]
2012-07-27 8:01 ` Keir Fraser
2012-07-30 7:53 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501238C1.4080709@oracle.com \
--to=joe.jin@oracle.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.