From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752319Ab2G0IX0 (ORCPT ); Fri, 27 Jul 2012 04:23:26 -0400 Received: from hqemgate04.nvidia.com ([216.228.121.35]:12143 "EHLO hqemgate04.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751735Ab2G0IXY (ORCPT ); Fri, 27 Jul 2012 04:23:24 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Fri, 27 Jul 2012 01:18:50 -0700 Message-ID: <50124D54.3020405@nvidia.com> Date: Fri, 27 Jul 2012 13:42:04 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7 MIME-Version: 1.0 To: Vinod Koul CC: "dan.j.williams@intel.com" , Stephen Warren , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V2] dma: tegra: enable/disable dma clock References: <1342771268-5252-1-git-send-email-ldewangan@nvidia.com> <1343106498.1726.5974.camel@vkoul-udesk3> <500E2BE0.7060602@nvidia.com> In-Reply-To: <500E2BE0.7060602@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 24 July 2012 10:30 AM, Laxman Dewangan wrote: > On Tuesday 24 July 2012 10:38 AM, Vinod Koul wrote: >> On Fri, 2012-07-20 at 13:31 +0530, Laxman Dewangan wrote: >>> Enable the DMA clock when allocating channel and >>> disable clock when freeing channels. >>> >>> Signed-off-by: Laxman Dewangan >>> --- >>> + clk_disable_unprepare(tdma->dma_clk); >> What if another channel is active, disabling clock can cause bad >> behavior. You should check here if all channels are idle and then >> disable, or is this handled by clock API? > Yes, clock driver keeps the reference count and so client driver need > not to take care. > Hi Vinod, Is there any thing remaining from my side here? Is it possible to make it for K3.6? Thanks, Laxman