From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yasuaki Ishimatsu Subject: Re: [RFC PATCH v5 19/19] memory-hotplug: remove sysfs file of node Date: Fri, 27 Jul 2012 19:45:02 +0900 Message-ID: <5012712E.9000005@jp.fujitsu.com> References: <50126B83.3050201@cn.fujitsu.com> <50126F21.803@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <50126F21.803@cn.fujitsu.com> Sender: owner-linux-mm@kvack.org To: Wen Congyang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org, cmetcalf@tilera.com, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org, cl@linux.com, minchan.kim@gmail.com, akpm@linux-foundation.org, kosaki.motohiro@jp.fujitsu.com List-Id: linux-acpi@vger.kernel.org Hi Wen, 2012/07/27 19:36, Wen Congyang wrote: > From: Yasuaki Ishimatsu > > The patch adds node_set_offline() and unregister_one_node() to remove_memory() > for removing sysfs file of node. > > CC: David Rientjes > CC: Jiang Liu > CC: Len Brown > CC: Benjamin Herrenschmidt > CC: Paul Mackerras > CC: Christoph Lameter > Cc: Minchan Kim > CC: Andrew Morton > CC: KOSAKI Motohiro > CC: Wen Congyang > Signed-off-by: Yasuaki Ishimatsu > --- > mm/memory_hotplug.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 5ac035f..5681968 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1267,6 +1267,11 @@ int __ref remove_memory(int nid, u64 start, u64 size) > /* remove memmap entry */ > firmware_map_remove(start, start + size, "System RAM"); > > + if (!node_present_pages(nid)) { Applying [PATCH v5 17/19], pgdat->node_spanned_pages can become 0 when all memory of the pgdat is removed. When pgdat->node_spanned_pages is 0, it means the pgdat has no memory. So I think node_spanned_pages() is better. Thanks, Yasuaki Ishimatsu > + node_set_offline(nid); > + unregister_one_node(nid); > + } > + > arch_remove_memory(start, size); > out: > unlock_memory_hotplug(); > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yasuaki Ishimatsu Date: Fri, 27 Jul 2012 10:45:02 +0000 Subject: Re: [RFC PATCH v5 19/19] memory-hotplug: remove sysfs file of node Message-Id: <5012712E.9000005@jp.fujitsu.com> List-Id: References: <50126B83.3050201@cn.fujitsu.com> <50126F21.803@cn.fujitsu.com> In-Reply-To: <50126F21.803@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wen Congyang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org, cmetcalf@tilera.com, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org, cl@linux.com, minchan.kim@gmail.com, akpm@linux-foundation.org, kosaki.motohiro@jp.fujitsu.com Hi Wen, 2012/07/27 19:36, Wen Congyang wrote: > From: Yasuaki Ishimatsu > > The patch adds node_set_offline() and unregister_one_node() to remove_memory() > for removing sysfs file of node. > > CC: David Rientjes > CC: Jiang Liu > CC: Len Brown > CC: Benjamin Herrenschmidt > CC: Paul Mackerras > CC: Christoph Lameter > Cc: Minchan Kim > CC: Andrew Morton > CC: KOSAKI Motohiro > CC: Wen Congyang > Signed-off-by: Yasuaki Ishimatsu > --- > mm/memory_hotplug.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 5ac035f..5681968 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1267,6 +1267,11 @@ int __ref remove_memory(int nid, u64 start, u64 size) > /* remove memmap entry */ > firmware_map_remove(start, start + size, "System RAM"); > > + if (!node_present_pages(nid)) { Applying [PATCH v5 17/19], pgdat->node_spanned_pages can become 0 when all memory of the pgdat is removed. When pgdat->node_spanned_pages is 0, it means the pgdat has no memory. So I think node_spanned_pages() is better. Thanks, Yasuaki Ishimatsu > + node_set_offline(nid); > + unregister_one_node(nid); > + } > + > arch_remove_memory(start, size); > out: > unlock_memory_hotplug(); > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fgwmail6.fujitsu.co.jp (fgwmail6.fujitsu.co.jp [192.51.44.36]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 1C2F42C0092 for ; Fri, 27 Jul 2012 20:45:33 +1000 (EST) Received: from m2.gw.fujitsu.co.jp (unknown [10.0.50.72]) by fgwmail6.fujitsu.co.jp (Postfix) with ESMTP id 435F63EE0C2 for ; Fri, 27 Jul 2012 19:45:32 +0900 (JST) Received: from smail (m2 [127.0.0.1]) by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 2177645DE54 for ; Fri, 27 Jul 2012 19:45:32 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 0569E45DE4E for ; Fri, 27 Jul 2012 19:45:32 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id EA3E41DB8040 for ; Fri, 27 Jul 2012 19:45:31 +0900 (JST) Received: from g01jpexchkw05.g01.fujitsu.local (g01jpexchkw05.g01.fujitsu.local [10.0.194.44]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id A9C511DB803C for ; Fri, 27 Jul 2012 19:45:31 +0900 (JST) Message-ID: <5012712E.9000005@jp.fujitsu.com> Date: Fri, 27 Jul 2012 19:45:02 +0900 From: Yasuaki Ishimatsu MIME-Version: 1.0 To: Wen Congyang Subject: Re: [RFC PATCH v5 19/19] memory-hotplug: remove sysfs file of node References: <50126B83.3050201@cn.fujitsu.com> <50126F21.803@cn.fujitsu.com> In-Reply-To: <50126F21.803@cn.fujitsu.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Cc: linux-s390@vger.kernel.org, linux-ia64@vger.kernel.org, linux-acpi@vger.kernel.org, len.brown@intel.com, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, cmetcalf@tilera.com, linux-mm@kvack.org, paulus@samba.org, minchan.kim@gmail.com, kosaki.motohiro@jp.fujitsu.com, rientjes@google.com, cl@linux.com, linuxppc-dev@lists.ozlabs.org, akpm@linux-foundation.org, liuj97@gmail.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Wen, 2012/07/27 19:36, Wen Congyang wrote: > From: Yasuaki Ishimatsu > > The patch adds node_set_offline() and unregister_one_node() to remove_memory() > for removing sysfs file of node. > > CC: David Rientjes > CC: Jiang Liu > CC: Len Brown > CC: Benjamin Herrenschmidt > CC: Paul Mackerras > CC: Christoph Lameter > Cc: Minchan Kim > CC: Andrew Morton > CC: KOSAKI Motohiro > CC: Wen Congyang > Signed-off-by: Yasuaki Ishimatsu > --- > mm/memory_hotplug.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 5ac035f..5681968 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1267,6 +1267,11 @@ int __ref remove_memory(int nid, u64 start, u64 size) > /* remove memmap entry */ > firmware_map_remove(start, start + size, "System RAM"); > > + if (!node_present_pages(nid)) { Applying [PATCH v5 17/19], pgdat->node_spanned_pages can become 0 when all memory of the pgdat is removed. When pgdat->node_spanned_pages is 0, it means the pgdat has no memory. So I think node_spanned_pages() is better. Thanks, Yasuaki Ishimatsu > + node_set_offline(nid); > + unregister_one_node(nid); > + } > + > arch_remove_memory(start, size); > out: > unlock_memory_hotplug(); > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752034Ab2G0Kpf (ORCPT ); Fri, 27 Jul 2012 06:45:35 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:50298 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751107Ab2G0Kpd (ORCPT ); Fri, 27 Jul 2012 06:45:33 -0400 X-SecurityPolicyCheck: OK by SHieldMailChecker v1.7.4 Message-ID: <5012712E.9000005@jp.fujitsu.com> Date: Fri, 27 Jul 2012 19:45:02 +0900 From: Yasuaki Ishimatsu User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: Wen Congyang CC: , , , , , , , , , , , , , , , , Subject: Re: [RFC PATCH v5 19/19] memory-hotplug: remove sysfs file of node References: <50126B83.3050201@cn.fujitsu.com> <50126F21.803@cn.fujitsu.com> In-Reply-To: <50126F21.803@cn.fujitsu.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wen, 2012/07/27 19:36, Wen Congyang wrote: > From: Yasuaki Ishimatsu > > The patch adds node_set_offline() and unregister_one_node() to remove_memory() > for removing sysfs file of node. > > CC: David Rientjes > CC: Jiang Liu > CC: Len Brown > CC: Benjamin Herrenschmidt > CC: Paul Mackerras > CC: Christoph Lameter > Cc: Minchan Kim > CC: Andrew Morton > CC: KOSAKI Motohiro > CC: Wen Congyang > Signed-off-by: Yasuaki Ishimatsu > --- > mm/memory_hotplug.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 5ac035f..5681968 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1267,6 +1267,11 @@ int __ref remove_memory(int nid, u64 start, u64 size) > /* remove memmap entry */ > firmware_map_remove(start, start + size, "System RAM"); > > + if (!node_present_pages(nid)) { Applying [PATCH v5 17/19], pgdat->node_spanned_pages can become 0 when all memory of the pgdat is removed. When pgdat->node_spanned_pages is 0, it means the pgdat has no memory. So I think node_spanned_pages() is better. Thanks, Yasuaki Ishimatsu > + node_set_offline(nid); > + unregister_one_node(nid); > + } > + > arch_remove_memory(start, size); > out: > unlock_memory_hotplug(); >