Re: [PATCH 1/3] ARM: tegra: Add Avionic Design Plutux support

[Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>]

On 07/25/2012 09:06 AM, Thierry Reding wrote:
> The Plutux is a set-top box device based on the Tamonten SOM and can be
> connected to a display via HDMI.

> diff --git a/arch/arm/boot/dts/tegra20-plutux.dts b/arch/arm/boot/dts/tegra20-plutux.dts

> +	regulators {
> +		compatible = "simple-bus";
> +
> +		#address-cells = <1>;
> +		#size-cells = <1>;

Depending on the outcome of the simple-bus discussion I mentioned on
IRC, this might want to be updated to match that. We'll see!

> +	sound {
> +		compatible = "nvidia,tegra-audio-wm8903-harmony",
> +			     "nvidia,tegra-audio-wm8903";

I think that first compatible value should be more like
"at,tegra-audio-plutux" or something like that; the driver itself
matches on "nvidia,tegra-audio-wm8903" only, and the first compatible
value is just in case we ever need board-specific fixes/hacks in the driver.

> diff --git a/arch/arm/mach-tegra/Makefile.boot b/arch/arm/mach-tegra/Makefile.boot

>  dtb-$(CONFIG_ARCH_TEGRA_2x_SOC) += tegra20-trimslice.dtb
>  dtb-$(CONFIG_ARCH_TEGRA_2x_SOC) += tegra20-ventana.dtb
>  dtb-$(CONFIG_ARCH_TEGRA_2x_SOC) += tegra20-whistler.dtb
> +dtb-$(CONFIG_ARCH_TEGRA_2x_SOC) += tegra20-plutux.dtb
>  dtb-$(CONFIG_ARCH_TEGRA_3x_SOC) += tegra30-cardhu.dtb

It'd be nice to keep that sorted first on 2x/3x SoC version, then
alphabetically.