From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Kardashevskiy Subject: Re: [Qemu-devel] [RFC PATCH] vfio: VFIO PCI driver for Qemu Date: Sat, 28 Jul 2012 12:55:56 +1000 Message-ID: <501354BC.9060405@ozlabs.ru> References: <20120725165948.17260.82862.stgit@bling.home> Mime-Version: 1.0 Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Cc: Alex Williamson , qemu-devel@nongnu.org, kvm@vger.kernel.org To: Blue Swirl Return-path: Received: from mail-pb0-f46.google.com ([209.85.160.46]:62011 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752772Ab2G1Cz6 (ORCPT ); Fri, 27 Jul 2012 22:55:58 -0400 Received: by pbbrp8 with SMTP id rp8so6016161pbb.19 for ; Fri, 27 Jul 2012 19:55:58 -0700 (PDT) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 28/07/12 05:22, Blue Swirl wrote: > On Wed, Jul 25, 2012 at 5:03 PM, Alex Williamson >> + >> +static void vfio_enable_intx_kvm(VFIODevice *vdev) >> +{ >> +#ifdef CONFIG_KVM > > These shouldn't be needed. The device will not be useful without KVM, > so the file shouldn't be compiled for non-KVM case at all. It compiles without --enable-kvm and works in ppc64 full emulation though. Not very practical but it still can be used for debugging ppc64 drivers on real PCI hardware on x86 machine. -- Alexey