From: Jiri Slaby <jslaby@suse.cz>
To: Baodong Chen <chenbdchenbd@gmail.com>
Cc: gregkh@linuxfoundation.org, davem@davemloft.net,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging:net:fixed to fit tty_driver's kref field
Date: Sun, 29 Jul 2012 13:16:44 +0200 [thread overview]
Message-ID: <50151B9C.1080407@suse.cz> (raw)
In-Reply-To: <1343551248-3447-1-git-send-email-chenbdchenbd@gmail.com>
On 07/29/2012 10:40 AM, Baodong Chen wrote:
> Fixed code to fix tty_driver's kref field
> checkpatch.pl clean up
> Signed-off-by: Baodong Chen <chenbdchenbd@gmail.com>
NACK. Please read Documentation/SubmittingPatches first.
This is an unreviewable patch. You do too many diverse changes in one
patch. Make your changes separate.
> ---
> drivers/staging/net/pc300_tty.c | 763 ++++++++++++++++++++-------------------
> 1 files changed, 386 insertions(+), 377 deletions(-)
>
> diff --git a/drivers/staging/net/pc300_tty.c b/drivers/staging/net/pc300_tty.c
> index 4709f42..859f680 100644
> --- a/drivers/staging/net/pc300_tty.c
> +++ b/drivers/staging/net/pc300_tty.c
> @@ -9,7 +9,7 @@
> * modify it under the terms of the GNU General Public License
> * as published by the Free Software Foundation; either version
> * 2 of the License, or (at your option) any later version.
> - *
> + *
> * $Log: pc300_tty.c,v $
> * Revision 3.7 2002/03/07 14:17:09 henrique
> * License data fixed
...
regards,
--
js
suse labs
next prev parent reply other threads:[~2012-07-29 11:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-29 8:40 [PATCH] staging:net:fixed to fit tty_driver's kref field Baodong Chen
2012-07-29 11:16 ` Jiri Slaby [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-07-29 14:06 Baodong Chen
2012-07-29 19:39 ` Sam Ravnborg
2012-07-31 12:54 ` Baodong Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50151B9C.1080407@suse.cz \
--to=jslaby@suse.cz \
--cc=chenbdchenbd@gmail.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.