From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wen Congyang Subject: Re: [RFC PATCH v5 05/19] memory-hotplug: check whether memory is present or not Date: Mon, 30 Jul 2012 09:57:33 +0800 Message-ID: <5015EA0D.9050501@cn.fujitsu.com> References: <50126B83.3050201@cn.fujitsu.com> <50126D44.7070608@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: owner-linux-mm@kvack.org To: Tony Luck Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org, cmetcalf@tilera.com, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org, cl@linux.com, minchan.kim@gmail.com, akpm@linux-foundation.org, kosaki.motohiro@jp.fujitsu.com, Yasuaki ISIMATU List-Id: linux-acpi@vger.kernel.org At 07/28/2012 04:17 AM, Tony Luck Wrote: > On Fri, Jul 27, 2012 at 3:28 AM, Wen Congyang wrote: >> +static inline int pfns_present(unsigned long pfn, unsigned long nr_pages) >> +{ >> + int i; >> + for (i = 0; i < nr_pages; i++) { >> + if (pfn_present(pfn + 1)) > > Typo? I think you meant "pfn + i" Typo error. Thanks for pointing it out. Wen Congyang > >> + continue; >> + else >> + return -EINVAL; >> + } >> + return 0; >> +} > > -Tony > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wen Congyang Date: Mon, 30 Jul 2012 01:57:33 +0000 Subject: Re: [RFC PATCH v5 05/19] memory-hotplug: check whether memory is present or not Message-Id: <5015EA0D.9050501@cn.fujitsu.com> List-Id: References: <50126B83.3050201@cn.fujitsu.com> <50126D44.7070608@cn.fujitsu.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tony Luck Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org, cmetcalf@tilera.com, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org, cl@linux.com, minchan.kim@gmail.com, akpm@linux-foundation.org, kosaki.motohiro@jp.fujitsu.com, Yasuaki ISIMATU At 07/28/2012 04:17 AM, Tony Luck Wrote: > On Fri, Jul 27, 2012 at 3:28 AM, Wen Congyang wrote: >> +static inline int pfns_present(unsigned long pfn, unsigned long nr_pages) >> +{ >> + int i; >> + for (i = 0; i < nr_pages; i++) { >> + if (pfn_present(pfn + 1)) > > Typo? I think you meant "pfn + i" Typo error. Thanks for pointing it out. Wen Congyang > >> + continue; >> + else >> + return -EINVAL; >> + } >> + return 0; >> +} > > -Tony > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from song.cn.fujitsu.com (unknown [222.73.24.84]) by ozlabs.org (Postfix) with ESMTP id 6CC422C008D for ; Mon, 30 Jul 2012 11:52:45 +1000 (EST) Message-ID: <5015EA0D.9050501@cn.fujitsu.com> Date: Mon, 30 Jul 2012 09:57:33 +0800 From: Wen Congyang MIME-Version: 1.0 To: Tony Luck Subject: Re: [RFC PATCH v5 05/19] memory-hotplug: check whether memory is present or not References: <50126B83.3050201@cn.fujitsu.com> <50126D44.7070608@cn.fujitsu.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Cc: linux-s390@vger.kernel.org, linux-ia64@vger.kernel.org, linux-acpi@vger.kernel.org, len.brown@intel.com, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, cmetcalf@tilera.com, linux-mm@kvack.org, Yasuaki ISIMATU , paulus@samba.org, minchan.kim@gmail.com, kosaki.motohiro@jp.fujitsu.com, rientjes@google.com, cl@linux.com, linuxppc-dev@lists.ozlabs.org, akpm@linux-foundation.org, liuj97@gmail.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , At 07/28/2012 04:17 AM, Tony Luck Wrote: > On Fri, Jul 27, 2012 at 3:28 AM, Wen Congyang wrote: >> +static inline int pfns_present(unsigned long pfn, unsigned long nr_pages) >> +{ >> + int i; >> + for (i = 0; i < nr_pages; i++) { >> + if (pfn_present(pfn + 1)) > > Typo? I think you meant "pfn + i" Typo error. Thanks for pointing it out. Wen Congyang > >> + continue; >> + else >> + return -EINVAL; >> + } >> + return 0; >> +} > > -Tony > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753976Ab2G3Bws (ORCPT ); Sun, 29 Jul 2012 21:52:48 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:65153 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753861Ab2G3Bwp (ORCPT ); Sun, 29 Jul 2012 21:52:45 -0400 X-IronPort-AV: E=Sophos;i="4.77,676,1336320000"; d="scan'208";a="5504765" Message-ID: <5015EA0D.9050501@cn.fujitsu.com> Date: Mon, 30 Jul 2012 09:57:33 +0800 From: Wen Congyang User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100413 Fedora/3.0.4-2.fc13 Thunderbird/3.0.4 MIME-Version: 1.0 To: Tony Luck CC: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org, cmetcalf@tilera.com, rientjes@google.com, liuj97@gmail.com, len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org, cl@linux.com, minchan.kim@gmail.com, akpm@linux-foundation.org, kosaki.motohiro@jp.fujitsu.com, Yasuaki ISIMATU Subject: Re: [RFC PATCH v5 05/19] memory-hotplug: check whether memory is present or not References: <50126B83.3050201@cn.fujitsu.com> <50126D44.7070608@cn.fujitsu.com> In-Reply-To: X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2012/07/30 09:53:06, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2012/07/30 09:53:19, Serialize complete at 2012/07/30 09:53:19 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At 07/28/2012 04:17 AM, Tony Luck Wrote: > On Fri, Jul 27, 2012 at 3:28 AM, Wen Congyang wrote: >> +static inline int pfns_present(unsigned long pfn, unsigned long nr_pages) >> +{ >> + int i; >> + for (i = 0; i < nr_pages; i++) { >> + if (pfn_present(pfn + 1)) > > Typo? I think you meant "pfn + i" Typo error. Thanks for pointing it out. Wen Congyang > >> + continue; >> + else >> + return -EINVAL; >> + } >> + return 0; >> +} > > -Tony >