From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 13/18] ARM: ux500: Add ux500 PCM to DB8500 Device Tree Date: Mon, 30 Jul 2012 08:32:43 +0100 Message-ID: <5016389B.4020003@linaro.org> References: <1343393162-11938-1-git-send-email-lee.jones@linaro.org> <1343393162-11938-14-git-send-email-lee.jones@linaro.org> <20120729205001.GK4384@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ee0-f51.google.com (mail-ee0-f51.google.com [74.125.83.51]) by alsa0.perex.cz (Postfix) with ESMTP id 4644426525A for ; Mon, 30 Jul 2012 09:32:43 +0200 (CEST) Received: by eeke50 with SMTP id e50so922881eek.38 for ; Mon, 30 Jul 2012 00:32:45 -0700 (PDT) In-Reply-To: <20120729205001.GK4384@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: ola.o.lilja@stericsson.com, alsa-devel@alsa-project.org, linus.walleij@stericsson.com, arnd@arndb.de, olalilja@yahoo.se, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, lrg@ti.com, linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org T24gMjkvMDcvMTIgMjE6NTAsIE1hcmsgQnJvd24gd3JvdGU6Cj4gT24gRnJpLCBKdWwgMjcsIDIw MTIgYXQgMDE6NDU6NTdQTSArMDEwMCwgTGVlIEpvbmVzIHdyb3RlOgo+PiBOb3RoaW5nIHNwZWNp YWwgaGVyZS4gV2UncmUgb25seSBwcm92aWRpbmcgYSBjb21wYXRpYmxlIHN0cmluZwo+PiB0byBl bnN1cmUgdGhlIGRyaXZlciBpcyBwcm9iZWQgdXNpbmcgYSBEZXZpY2UgVHJlZSBib290Lgo+Cj4+ ICsJCXBjbTogdXg1MDAtcGNtIHsKPj4gKwkJCWNvbXBhdGlibGUgPSAic3Rlcmljc3Nvbix1eDUw MC1wY20iOwo+PiArCQl9Owo+PiArCj4KPiBPbmUgb2YgdHdvIHRoaW5ncyBpcyB3cm9uZyBoZXJl LiAgRWl0aGVyIHlvdSd2ZSBub3QgcHJvdmlkZWQgYW55Cj4gaW5mb3JtYXRpb24gYWJvdXQgdGhl IGhhcmR3YXJlIHNvIHRoZSBkcml2ZXIgd29uJ3QgYmUgYWJsZSB0byB3b3JrIG91dAo+IHdoYXQg dG8gdGFsayB0byBvciB5b3UndmUgbm90IHByb3ZpZGVkIGFueSBkYXRhIHNvIHlvdSdyZSByZWdp c3RlcmluZyBhCj4gcHVyZWx5IHZpcnR1YWwgTGludXgtaW50ZXJuYWwgZGV2aWNlIHZpYSB0aGUg ZGV2aWNlIHRyZWUuCj4KPiBPbmNlIG1vcmUsIHRoZSBpZGVhIGhlcmUgaXMgdG8gZGVzY3JpYmUg dGhlIGhhcmR3YXJlIG5vdCB0byBkdW1wIExpbnV4J3MKPiBpbnRlcm5hbCBkYXRhIHN0cnVjdHVy ZXMgaW50byB0aGUgZGV2aWNlIHRyZWUuCgpXZSB1c2UgaXQgcmVnaXN0ZXIgdGhlIGRyaXZlciBm b3IgcHJvYmUoKWluZy4gSW4gdGhlIHNhbWUgd2F5IHdlIGRvIGZvciAKdGhlIFBNVSBhbmQgUmVn dWxhdG9ycy4gQWxsIHRocmVlIG9mIHdoaWNoIGFjdHVhbGx5IGJlbG9uZyB0byBhIApkaWZmZXJl bnQgaGFyZHdhcmUgYmxvY2suIERvIHlvdSBrbm93IG9mIGEgYmV0dGVyIHdheSB0byByZWdpc3Rl ciB0aG9zZSAKZGV2aWNlcz8KCi0tIApMZWUgSm9uZXMKTGluYXJvIFNULUVyaWNzc29uIExhbmRp bmcgVGVhbSBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBUk0g U29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkFsc2EtZGV2ZWwgbWFpbGluZyBs aXN0CkFsc2EtZGV2ZWxAYWxzYS1wcm9qZWN0Lm9yZwpodHRwOi8vbWFpbG1hbi5hbHNhLXByb2pl Y3Qub3JnL21haWxtYW4vbGlzdGluZm8vYWxzYS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Mon, 30 Jul 2012 08:32:43 +0100 Subject: [PATCH 13/18] ARM: ux500: Add ux500 PCM to DB8500 Device Tree In-Reply-To: <20120729205001.GK4384@opensource.wolfsonmicro.com> References: <1343393162-11938-1-git-send-email-lee.jones@linaro.org> <1343393162-11938-14-git-send-email-lee.jones@linaro.org> <20120729205001.GK4384@opensource.wolfsonmicro.com> Message-ID: <5016389B.4020003@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 29/07/12 21:50, Mark Brown wrote: > On Fri, Jul 27, 2012 at 01:45:57PM +0100, Lee Jones wrote: >> Nothing special here. We're only providing a compatible string >> to ensure the driver is probed using a Device Tree boot. > >> + pcm: ux500-pcm { >> + compatible = "stericsson,ux500-pcm"; >> + }; >> + > > One of two things is wrong here. Either you've not provided any > information about the hardware so the driver won't be able to work out > what to talk to or you've not provided any data so you're registering a > purely virtual Linux-internal device via the device tree. > > Once more, the idea here is to describe the hardware not to dump Linux's > internal data structures into the device tree. We use it register the driver for probe()ing. In the same way we do for the PMU and Regulators. All three of which actually belong to a different hardware block. Do you know of a better way to register those devices? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752321Ab2G3Hcr (ORCPT ); Mon, 30 Jul 2012 03:32:47 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:51611 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751376Ab2G3Hcq (ORCPT ); Mon, 30 Jul 2012 03:32:46 -0400 Message-ID: <5016389B.4020003@linaro.org> Date: Mon, 30 Jul 2012 08:32:43 +0100 From: Lee Jones User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Mark Brown CC: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, linus.walleij@stericsson.com, arnd@arndb.de, olalilja@yahoo.se, ola.o.lilja@stericsson.com, alsa-devel@alsa-project.org, lrg@ti.com Subject: Re: [PATCH 13/18] ARM: ux500: Add ux500 PCM to DB8500 Device Tree References: <1343393162-11938-1-git-send-email-lee.jones@linaro.org> <1343393162-11938-14-git-send-email-lee.jones@linaro.org> <20120729205001.GK4384@opensource.wolfsonmicro.com> In-Reply-To: <20120729205001.GK4384@opensource.wolfsonmicro.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/07/12 21:50, Mark Brown wrote: > On Fri, Jul 27, 2012 at 01:45:57PM +0100, Lee Jones wrote: >> Nothing special here. We're only providing a compatible string >> to ensure the driver is probed using a Device Tree boot. > >> + pcm: ux500-pcm { >> + compatible = "stericsson,ux500-pcm"; >> + }; >> + > > One of two things is wrong here. Either you've not provided any > information about the hardware so the driver won't be able to work out > what to talk to or you've not provided any data so you're registering a > purely virtual Linux-internal device via the device tree. > > Once more, the idea here is to describe the hardware not to dump Linux's > internal data structures into the device tree. We use it register the driver for probe()ing. In the same way we do for the PMU and Regulators. All three of which actually belong to a different hardware block. Do you know of a better way to register those devices? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog