From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 17/18] ARM: ux500: Add all encompassing Sound node to DB8500 Device Tree Date: Mon, 30 Jul 2012 08:35:18 +0100 Message-ID: <50163936.1050901@linaro.org> References: <1343393162-11938-1-git-send-email-lee.jones@linaro.org> <1343393162-11938-18-git-send-email-lee.jones@linaro.org> <20120729205227.GL4384@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ee0-f51.google.com (mail-ee0-f51.google.com [74.125.83.51]) by alsa0.perex.cz (Postfix) with ESMTP id 355AB26526D for ; Mon, 30 Jul 2012 09:35:18 +0200 (CEST) Received: by eeke50 with SMTP id e50so923510eek.38 for ; Mon, 30 Jul 2012 00:35:20 -0700 (PDT) In-Reply-To: <20120729205227.GL4384@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: ola.o.lilja@stericsson.com, alsa-devel@alsa-project.org, linus.walleij@stericsson.com, arnd@arndb.de, olalilja@yahoo.se, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, lrg@ti.com, linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org T24gMjkvMDcvMTIgMjE6NTIsIE1hcmsgQnJvd24gd3JvdGU6Cj4gT24gRnJpLCBKdWwgMjcsIDIw MTIgYXQgMDE6NDY6MDFQTSArMDEwMCwgTGVlIEpvbmVzIHdyb3RlOgo+Cj4+ICAgYXJjaC9hcm0v Ym9vdC9kdHMvZGI4NTAwLmR0c2kgfCAgICA4ICsrKysrKysrCj4KPiBUaGlzIGlzIGEgZ2VuZXJp YyBEVCBpbmNsdWRlIGZpbGUgYnV0Li4uCj4KPj4gKwkJc291bmQgewo+PiArCQkJY29tcGF0aWJs ZSA9ICJzdGVyaWNzc29uLHNuZC1zb2MtbW9wNTAwIjsKPj4gKwo+PiArCQkJc3Rlcmljc3Nvbixw bGF0Zm9ybS1wY20tZG1hID0gPCZwY20+Owo+PiArCQkJc3Rlcmljc3NvbixjcHUtZGFpID0gPCZt c3AxICZtc3AzPjsKPj4gKwkJCXN0ZXJpY3Nzb24sYXVkaW8tY29kZWMgPSA8JmNvZGVjPjsKPj4g KwkJfTsKPgo+IC4uLnRoaXMgaXMgY2xlYXJseSB0aGUgYm9hcmQtc3BlY2lmaWMgc2V0dXAgZm9y IHRoZSBzeXN0ZW0sIHNob3dpbmcgaG93Cj4gdGhlIENQVSBhbmQgQ09ERUMgYXJlIGhvb2tlZCB1 cC4gIFRoaXMgc2hvdWxkIHRoZXJlZm9yZSBiZSBpbiB0aGUgRFQgZm9yCj4gd2hhdGV2ZXIgYm9h cmQgdGhpcyBpcyB5b3UncmUgd29ya2luZyBvbi4KCkkgZG9uJ3QgdGhpbmsgaXQncyBib2FyZCBz cGVjaWZpYy4gSSBiZWxpZXZlIHRoaXMgaXMgdGhlIHNldHVwIG9uIGFsbCAKZGI4NTAwIHBsYXRm b3Jtcy4gSSdtIGhhcHB5IHRvIGJlIHRvbGQgSSdtIHdyb25nIGhlcmUsIGluIHdoaWNoIGNhc2Ug SSAKY2FuIG1vdmUgaXQgdG8gdGhlIGJvYXJkIHNwZWNpZmljIGZpbGVzLgoKLS0gCkxlZSBKb25l cwpMaW5hcm8gU1QtRXJpY3Nzb24gTGFuZGluZyBUZWFtIExlYWQKTGluYXJvLm9yZyDilIIgT3Bl biBzb3VyY2Ugc29mdHdhcmUgZm9yIEFSTSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwg VHdpdHRlciB8IEJsb2cKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KQWxzYS1kZXZlbCBtYWlsaW5nIGxpc3QKQWxzYS1kZXZlbEBhbHNhLXByb2plY3Qub3Jn Cmh0dHA6Ly9tYWlsbWFuLmFsc2EtcHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbHNhLWRl dmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Mon, 30 Jul 2012 08:35:18 +0100 Subject: [PATCH 17/18] ARM: ux500: Add all encompassing Sound node to DB8500 Device Tree In-Reply-To: <20120729205227.GL4384@opensource.wolfsonmicro.com> References: <1343393162-11938-1-git-send-email-lee.jones@linaro.org> <1343393162-11938-18-git-send-email-lee.jones@linaro.org> <20120729205227.GL4384@opensource.wolfsonmicro.com> Message-ID: <50163936.1050901@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 29/07/12 21:52, Mark Brown wrote: > On Fri, Jul 27, 2012 at 01:46:01PM +0100, Lee Jones wrote: > >> arch/arm/boot/dts/db8500.dtsi | 8 ++++++++ > > This is a generic DT include file but... > >> + sound { >> + compatible = "stericsson,snd-soc-mop500"; >> + >> + stericsson,platform-pcm-dma = <&pcm>; >> + stericsson,cpu-dai = <&msp1 &msp3>; >> + stericsson,audio-codec = <&codec>; >> + }; > > ...this is clearly the board-specific setup for the system, showing how > the CPU and CODEC are hooked up. This should therefore be in the DT for > whatever board this is you're working on. I don't think it's board specific. I believe this is the setup on all db8500 platforms. I'm happy to be told I'm wrong here, in which case I can move it to the board specific files. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752489Ab2G3HfW (ORCPT ); Mon, 30 Jul 2012 03:35:22 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:47764 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751113Ab2G3HfV (ORCPT ); Mon, 30 Jul 2012 03:35:21 -0400 Message-ID: <50163936.1050901@linaro.org> Date: Mon, 30 Jul 2012 08:35:18 +0100 From: Lee Jones User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Mark Brown CC: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, linus.walleij@stericsson.com, arnd@arndb.de, olalilja@yahoo.se, ola.o.lilja@stericsson.com, alsa-devel@alsa-project.org, lrg@ti.com Subject: Re: [PATCH 17/18] ARM: ux500: Add all encompassing Sound node to DB8500 Device Tree References: <1343393162-11938-1-git-send-email-lee.jones@linaro.org> <1343393162-11938-18-git-send-email-lee.jones@linaro.org> <20120729205227.GL4384@opensource.wolfsonmicro.com> In-Reply-To: <20120729205227.GL4384@opensource.wolfsonmicro.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/07/12 21:52, Mark Brown wrote: > On Fri, Jul 27, 2012 at 01:46:01PM +0100, Lee Jones wrote: > >> arch/arm/boot/dts/db8500.dtsi | 8 ++++++++ > > This is a generic DT include file but... > >> + sound { >> + compatible = "stericsson,snd-soc-mop500"; >> + >> + stericsson,platform-pcm-dma = <&pcm>; >> + stericsson,cpu-dai = <&msp1 &msp3>; >> + stericsson,audio-codec = <&codec>; >> + }; > > ...this is clearly the board-specific setup for the system, showing how > the CPU and CODEC are hooked up. This should therefore be in the DT for > whatever board this is you're working on. I don't think it's board specific. I believe this is the setup on all db8500 platforms. I'm happy to be told I'm wrong here, in which case I can move it to the board specific files. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog