From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?windows-1252?Q?Christian_K=F6nig?= Subject: Re: [PATCH 1/2] radeon: simplify ZS buffer checking on r600 Date: Mon, 30 Jul 2012 10:29:04 +0200 Message-ID: <501645D0.5080400@vodafone.de> References: <1343570522-4080-1-git-send-email-maraeo@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: Received: from outgoing.email.vodafone.de (outgoing.email.vodafone.de [139.7.28.128]) by gabe.freedesktop.org (Postfix) with ESMTP id ABADC9E917 for ; Mon, 30 Jul 2012 01:29:08 -0700 (PDT) In-Reply-To: <1343570522-4080-1-git-send-email-maraeo@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: =?windows-1252?Q?Marek_Ol=9A=E1k?= Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org I wanted to work on something similar this week, cause we need some = updates for SI on this. So thx, you saved me some work here. And both patches are: Reviewed-by: Christian K=F6nig On 29.07.2012 16:02, Marek Ol=9A=E1k wrote: > Setting those flags has no effect anywhere else. > --- > radeon/radeon_surface.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/radeon/radeon_surface.c b/radeon/radeon_surface.c > index c80f7f4..5800c33 100644 > --- a/radeon/radeon_surface.c > +++ b/radeon/radeon_surface.c > @@ -385,14 +385,7 @@ static int r6_surface_init(struct radeon_surface_man= ager *surf_man, > /* tiling mode */ > mode =3D (surf->flags >> RADEON_SURF_MODE_SHIFT) & RADEON_SURF_MODE= _MASK; > = > - /* always enable z & stencil together */ > - if (surf->flags & RADEON_SURF_ZBUFFER) { > - surf->flags |=3D RADEON_SURF_SBUFFER; > - } > - if (surf->flags & RADEON_SURF_SBUFFER) { > - surf->flags |=3D RADEON_SURF_ZBUFFER; > - } > - if (surf->flags & RADEON_SURF_ZBUFFER) { > + if (surf->flags & (RADEON_SURF_ZBUFFER | RADEON_SURF_SBUFFER)) { > /* zbuffer only support 1D or 2D tiled surface */ > switch (mode) { > case RADEON_SURF_MODE_1D: