From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D87BC433EF for ; Tue, 15 Mar 2022 10:12:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346885AbiCOKNo (ORCPT ); Tue, 15 Mar 2022 06:13:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239017AbiCOKNo (ORCPT ); Tue, 15 Mar 2022 06:13:44 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD60C4FC6A for ; Tue, 15 Mar 2022 03:12:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7C423B811D8 for ; Tue, 15 Mar 2022 10:12:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5891C340ED; Tue, 15 Mar 2022 10:12:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647339148; bh=Exh3jqrZXT+4BSiAWg84ihue5Vz+THNPFoTVEsqYxCI=; h=Subject:From:To:Date:In-Reply-To:References:From; b=MeO1EHao2OGLV7APDEvX8dLgcZSCK38g7+hNvZtOmowm+R3iDMqJj8FyH5xsv25Oi TdF7gIguhfO0zCWvX0+bJKRvZOEYrj+VpUY2hiHyew5MMVSDsQZ7N/GA5KvCmA4qGL DL1yBxMpqHZQuMLwE99sHZASaoLgTwhGwaxPjhWc8FKYo7OEUVnsUXaYOsf68qTrNx KiN33CYZCJ0JvbkdT48vInCG8kRsdA2uFn/CXVAlg5SopbKkBvBtTNWYBHQZfiGGiR 5kFRLCkc8gEyJSR5rlUoOsxVhWWShy3aV6YVXBuqMgIYPfqG6aVH9sNaOnJ2sHeMic Av0TfLsxvLiNQ== Message-ID: <5016766a07f38d16e6fea66b2ad9da7076bf4a9b.camel@kernel.org> Subject: Re: [PATCH 0/3] ceph: support for sparse read in msgr2 crc path From: Jeff Layton To: Xiubo Li , ceph-devel@vger.kernel.org, idryomov@gmail.com Date: Tue, 15 Mar 2022 06:12:26 -0400 In-Reply-To: References: <20220309123323.20593-1-jlayton@kernel.org> Content-Type: text/plain; charset="ISO-8859-15" User-Agent: Evolution 3.42.4 (3.42.4-1.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org On Tue, 2022-03-15 at 14:23 +0800, Xiubo Li wrote: > Hi Jeff, > > I hit the following crash by using the latest wip-fscrypt branch: > > <5>[245348.815462] Key type ceph unregistered > <5>[245545.560567] Key type ceph registered > <6>[245545.566723] libceph: loaded (mon/osd proto 15/24) > <6>[245545.775116] ceph: loaded (mds proto 32) > <6>[245545.822200] libceph: mon2 (1)10.72.47.117:40843 session established > <6>[245545.829658] libceph: client5000 fsid > 2b9c5f33-3f43-4f89-945d-2a1b6372c5af > <4>[245583.531648] ------------[ cut here ]------------ > <2>[245583.531701] kernel BUG at net/ceph/messenger.c:1032! > <4>[245583.531929] invalid opcode: 0000 [#1] PREEMPT SMP KASAN NOPTI > <4>[245583.532030] CPU: 2 PID: 283539 Comm: kworker/2:0 Tainted: > G            E     5.17.0-rc6+ #98 > <4>[245583.532050] Hardware name: Red Hat RHEV Hypervisor, BIOS > 1.11.0-2.el7 04/01/2014 > <4>[245583.532086] Workqueue: ceph-msgr ceph_con_workfn [libceph] > <4>[245583.532380] RIP: 0010:ceph_msg_data_cursor_init+0x79/0x80 [libceph] > <4>[245583.532592] Code: 8d 7b 08 e8 39 99 00 dc 48 8d 7b 18 48 89 6b 08 > e8 ec 97 00 dc c7 43 18 00 00 00 00 48 89 df 5b 5d 41 5c e9 89 c7 ff ff > 0f 0b <0f> 0b 0f 0b 0f 1f 00 0f 1f 44 00 00 41 57 41 56 41 55 49 89 cd 41 > <4>[245583.532609] RSP: 0018:ffffc90018847c10 EFLAGS: 00010287 > <4>[245583.532654] RAX: 0000000000000000 RBX: ffff888244ff3850 RCX: > ffffffffc10bd850 > <4>[245583.532683] RDX: dffffc0000000000 RSI: ffff888244ff37d0 RDI: > ffff888244ff3838 > <4>[245583.532705] RBP: ffff888244ff37d0 R08: 00000000000000d1 R09: > ffffed10489fe701 > <4>[245583.532726] R10: ffff888244ff3804 R11: ffffed10489fe700 R12: > 00000000000000d1 > <4>[245583.532746] R13: ffff8882d1adb030 R14: ffff8882d1adb408 R15: > 0000000000000000 > <4>[245583.532764] FS:  0000000000000000(0000) GS:ffff8887ccd00000(0000) > knlGS:0000000000000000 > <4>[245583.532785] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > <4>[245583.532797] CR2: 00007fb991665000 CR3: 0000000368ebe001 CR4: > 00000000007706e0 > <4>[245583.532809] DR0: 0000000000000000 DR1: 0000000000000000 DR2: > 0000000000000000 > <4>[245583.532820] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: > 0000000000000400 > <4>[245583.532831] PKRU: 55555554 > <4>[245583.532840] Call Trace: > <4>[245583.532852]  > <4>[245583.532863]  ceph_con_v1_try_read+0xd21/0x15c0 [libceph] > <4>[245583.533124]  ? ceph_tcp_sendpage+0x100/0x100 [libceph] > <4>[245583.533348]  ? load_balance+0x1240/0x1240 > <4>[245583.533655]  ? dequeue_entity+0x18b/0x6f0 > <4>[245583.533690]  ? mutex_lock+0x8e/0xe0 > <4>[245583.533869]  ? __mutex_lock_slowpath+0x10/0x10 > <4>[245583.533887]  ? _raw_spin_unlock+0x16/0x30 > <4>[245583.533906]  ? __switch_to+0x2fa/0x690 > <4>[245583.534007]  ceph_con_workfn+0x545/0x940 [libceph] > <4>[245583.534234]  process_one_work+0x3c1/0x6e0 > <4>[245583.534340]  worker_thread+0x57/0x580 > <4>[245583.534363]  ? process_one_work+0x6e0/0x6e0 > <4>[245583.534382]  kthread+0x160/0x190 > <4>[245583.534421]  ? kthread_complete_and_exit+0x20/0x20 > <4>[245583.534477]  ret_from_fork+0x1f/0x30 > <4>[245583.534544]  > ... > > <4>[245583.535413] RIP: 0010:ceph_msg_data_cursor_init+0x79/0x80 [libceph] > <4>[245583.535627] Code: 8d 7b 08 e8 39 99 00 dc 48 8d 7b 18 48 89 6b 08 > e8 ec 97 00 dc c7 43 18 00 00 00 00 48 89 df 5b 5d 41 5c e9 89 c7 ff ff > 0f 0b <0f> 0b 0f 0b 0f 1f 00 0f 1f 44 00 00 41 57 41 56 41 55 49 89 cd 41 > <4>[245583.535644] RSP: 0018:ffffc90018847c10 EFLAGS: 00010287 > <4>[245583.535720] RAX: 0000000000000000 RBX: ffff888244ff3850 RCX: > ffffffffc10bd850 > <4>[245583.535745] RDX: dffffc0000000000 RSI: ffff888244ff37d0 RDI: > ffff888244ff3838 > <4>[245583.535769] RBP: ffff888244ff37d0 R08: 00000000000000d1 R09: > ffffed10489fe701 > > Seems caused by the parse read ? > > You mean sparse read? Those patches aren't in the wip-fscrypt branch yet, so I wouldn't think them a factor here. What commit was at the top of your branch? If you're testing the latest sparse read patches on top of wip-fscrypt, then those only work with msgr2 so far. Using msgr1 with it is likely to have problems. -- Jeff Layton