From: Stanislav Kozina <skozina@redhat.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org
Subject: Re: Patch for panic in n_tty_read()
Date: Mon, 30 Jul 2012 13:58:52 +0200 [thread overview]
Message-ID: <501676FC.6020103@redhat.com> (raw)
In-Reply-To: <20120727135044.356823f4@pyramind.ukuu.org.uk>
Alan,
I am very sorry, but I don't see it. We didn't held the lock while
calling tty_audit_push() before, and we don't hold it after the patch
neither.
So what's the locking scheme change here? Is there some binding between
n_tty_read() and tty_audit_push() I just don't see?
Thank you,
-Stanislav
> Looks good to me. However it changes the locking rules on
> tty_audit_push() so please check the audit folks are ok with it. I don't
> think that causes any problems.
>
> Alan
next prev parent reply other threads:[~2012-07-30 11:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 15:41 Patch for panic in n_tty_read() Stanislav Kozina
2012-06-26 14:21 ` Alan Cox
2012-07-20 12:18 ` Stanislav Kozina
2012-07-20 15:11 ` Alan Cox
2012-07-27 12:05 ` Stanislav Kozina
2012-07-27 12:50 ` Alan Cox
2012-07-30 11:58 ` Stanislav Kozina [this message]
2012-08-08 7:58 ` Stanislav Kozina
2012-08-08 9:00 ` Alan Cox
2012-08-08 12:09 ` Stanislav Kozina
2012-08-08 12:26 ` Alan Cox
2012-08-08 14:32 ` Stanislav Kozina
2012-08-08 14:28 ` [PATCH V2] [tty] Fix possible race " Stanislav Kozina
2012-08-08 15:27 ` Alan Cox
2012-08-09 11:16 ` Stanislaw Gruszka
2012-08-13 15:26 ` Stanislaw Gruszka
2012-08-14 11:15 ` Stanislav Kozina
2012-08-09 11:24 ` Stanislav Kozina
2012-08-09 12:35 ` Alan Cox
2012-08-10 10:52 ` Stanislav Kozina
2012-08-10 10:51 ` [PATCH] Remove BUG_ON from n_tty_read() Stanislav Kozina
2012-08-10 12:29 ` Stanislaw Gruszka
2012-08-10 14:53 ` Stanislav Kozina
2012-08-10 14:38 ` [PATCH V2] " Stanislav Kozina
2012-08-16 7:52 ` Stanislav Kozina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501676FC.6020103@redhat.com \
--to=skozina@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.