From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 05/18] ASoC: Ux500: Enable ux500 MSP driver for Device Tree Date: Mon, 30 Jul 2012 14:57:12 +0100 Message-ID: <501692B8.6050102@linaro.org> References: <1343393162-11938-1-git-send-email-lee.jones@linaro.org> <1343393162-11938-6-git-send-email-lee.jones@linaro.org> <20120729204218.GI4384@opensource.wolfsonmicro.com> <50162F70.2050900@linaro.org> <20120730133930.GB4468@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ee0-f51.google.com (mail-ee0-f51.google.com [74.125.83.51]) by alsa0.perex.cz (Postfix) with ESMTP id 005922652FA for ; Mon, 30 Jul 2012 15:57:12 +0200 (CEST) Received: by eeke50 with SMTP id e50so1044172eek.38 for ; Mon, 30 Jul 2012 06:57:15 -0700 (PDT) In-Reply-To: <20120730133930.GB4468@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: ola.o.lilja@stericsson.com, alsa-devel@alsa-project.org, linus.walleij@stericsson.com, arnd@arndb.de, olalilja@yahoo.se, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, lrg@ti.com, linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org T24gMzAvMDcvMTIgMTQ6MzksIE1hcmsgQnJvd24gd3JvdGU6Cj4gT24gTW9uLCBKdWwgMzAsIDIw MTIgYXQgMDc6NTM6MzZBTSArMDEwMCwgTGVlIEpvbmVzIHdyb3RlOgo+PiBPbiAyOS8wNy8xMiAy MTo0MiwgTWFyayBCcm93biB3cm90ZToKPgo+Pj4+ICsJaWYgKG9mX2dldF9wcm9wZXJ0eShucCwg InN0ZXJpY3Nzb24sdXNlLXBpbmN0cmwiLCBOVUxMKSkKPgo+Pj4gVGhpcyBkb2Vzbid0IHNlZW0g cGFydGljdWxhcmx5IHNhbmUuLi4gIHdoeSBpcyB0aGlzIGNvbmRpdGlvbmFsPwo+Cj4+IEl0J3Mg Y29uZGl0aW9uYWwgYmVjYXVzZSBvbmx5IE1TUDEgYW5kIE1TUDMgaGF2ZSBwaW5jdHJsIHN1cHBv cnQuCj4KPiBXaHkgZG9lcyB0aGUgZHJpdmVyIGNhcmUgLSBkb2Vzbid0IHRoZSBwaW5jdHJsIGFi c3RyYWN0aW9uIGFuZC9vcgo+IGJpbmRpbmdzIGhhbmRsZSB0aGlzIHNlbnNpYmx5PwoKTm90IHdo ZW4gSSB0ZXN0ZWQgaXQuIHBpbmN0cmxfZ2V0KCkgY2FtZSBiYWNrICFJU19FUlIoKSBmb3IgTVNQ MCwgTVNQMiAmIApNU1AzLCB0aGVuIHdoZW4gaXQgd2VudCBvbiB0byBwaW5jdHJsX2xvb2t1cF9z dGF0ZSgpLCBvbmx5IHRoZW4gZGlkIGl0IApmYWlsLiBXb3VsZCBpdCBiZSBtb3JlIHNhbmUgdG8g cmV0cmFjdCB0aGUgZXJyb3IgbWVzc2FnZXMgYW5kIGp1c3QgbGV0IAppdCBmYWlsIHNpbGVudGx5 PyBJdCdzIGVpdGhlciB0aGF0IG9yIGhhdmUgbG90cyBvZiAiY291bGQgbm90IGdldCBNU1AgCmRl ZnN0YXRlIiBjbG9nZ2luZyB1cCB0aGUgbG9nLgoKLS0gCkxlZSBKb25lcwpMaW5hcm8gU1QtRXJp Y3Nzb24gTGFuZGluZyBUZWFtIExlYWQKTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdh cmUgZm9yIEFSTSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KQWxzYS1kZXZl bCBtYWlsaW5nIGxpc3QKQWxzYS1kZXZlbEBhbHNhLXByb2plY3Qub3JnCmh0dHA6Ly9tYWlsbWFu LmFsc2EtcHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbHNhLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Mon, 30 Jul 2012 14:57:12 +0100 Subject: [PATCH 05/18] ASoC: Ux500: Enable ux500 MSP driver for Device Tree In-Reply-To: <20120730133930.GB4468@opensource.wolfsonmicro.com> References: <1343393162-11938-1-git-send-email-lee.jones@linaro.org> <1343393162-11938-6-git-send-email-lee.jones@linaro.org> <20120729204218.GI4384@opensource.wolfsonmicro.com> <50162F70.2050900@linaro.org> <20120730133930.GB4468@opensource.wolfsonmicro.com> Message-ID: <501692B8.6050102@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 30/07/12 14:39, Mark Brown wrote: > On Mon, Jul 30, 2012 at 07:53:36AM +0100, Lee Jones wrote: >> On 29/07/12 21:42, Mark Brown wrote: > >>>> + if (of_get_property(np, "stericsson,use-pinctrl", NULL)) > >>> This doesn't seem particularly sane... why is this conditional? > >> It's conditional because only MSP1 and MSP3 have pinctrl support. > > Why does the driver care - doesn't the pinctrl abstraction and/or > bindings handle this sensibly? Not when I tested it. pinctrl_get() came back !IS_ERR() for MSP0, MSP2 & MSP3, then when it went on to pinctrl_lookup_state(), only then did it fail. Would it be more sane to retract the error messages and just let it fail silently? It's either that or have lots of "could not get MSP defstate" clogging up the log. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754420Ab2G3N5S (ORCPT ); Mon, 30 Jul 2012 09:57:18 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:62709 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754276Ab2G3N5Q (ORCPT ); Mon, 30 Jul 2012 09:57:16 -0400 Message-ID: <501692B8.6050102@linaro.org> Date: Mon, 30 Jul 2012 14:57:12 +0100 From: Lee Jones User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Mark Brown CC: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, linus.walleij@stericsson.com, arnd@arndb.de, olalilja@yahoo.se, ola.o.lilja@stericsson.com, alsa-devel@alsa-project.org, lrg@ti.com Subject: Re: [PATCH 05/18] ASoC: Ux500: Enable ux500 MSP driver for Device Tree References: <1343393162-11938-1-git-send-email-lee.jones@linaro.org> <1343393162-11938-6-git-send-email-lee.jones@linaro.org> <20120729204218.GI4384@opensource.wolfsonmicro.com> <50162F70.2050900@linaro.org> <20120730133930.GB4468@opensource.wolfsonmicro.com> In-Reply-To: <20120730133930.GB4468@opensource.wolfsonmicro.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/07/12 14:39, Mark Brown wrote: > On Mon, Jul 30, 2012 at 07:53:36AM +0100, Lee Jones wrote: >> On 29/07/12 21:42, Mark Brown wrote: > >>>> + if (of_get_property(np, "stericsson,use-pinctrl", NULL)) > >>> This doesn't seem particularly sane... why is this conditional? > >> It's conditional because only MSP1 and MSP3 have pinctrl support. > > Why does the driver care - doesn't the pinctrl abstraction and/or > bindings handle this sensibly? Not when I tested it. pinctrl_get() came back !IS_ERR() for MSP0, MSP2 & MSP3, then when it went on to pinctrl_lookup_state(), only then did it fail. Would it be more sane to retract the error messages and just let it fail silently? It's either that or have lots of "could not get MSP defstate" clogging up the log. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog