From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 13/18] ARM: ux500: Add ux500 PCM to DB8500 Device Tree Date: Mon, 30 Jul 2012 15:26:58 +0100 Message-ID: <501699B2.7030002@linaro.org> References: <1343393162-11938-1-git-send-email-lee.jones@linaro.org> <1343393162-11938-14-git-send-email-lee.jones@linaro.org> <20120729205001.GK4384@opensource.wolfsonmicro.com> <5016389B.4020003@linaro.org> <20120730134054.GC4468@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ee0-f51.google.com (mail-ee0-f51.google.com [74.125.83.51]) by alsa0.perex.cz (Postfix) with ESMTP id D43D92652FA for ; Mon, 30 Jul 2012 16:26:59 +0200 (CEST) Received: by eeke50 with SMTP id e50so1053971eek.38 for ; Mon, 30 Jul 2012 07:27:02 -0700 (PDT) In-Reply-To: <20120730134054.GC4468@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: ola.o.lilja@stericsson.com, alsa-devel@alsa-project.org, linus.walleij@stericsson.com, arnd@arndb.de, olalilja@yahoo.se, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, lrg@ti.com, linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org T24gMzAvMDcvMTIgMTQ6NDAsIE1hcmsgQnJvd24gd3JvdGU6Cj4gT24gTW9uLCBKdWwgMzAsIDIw MTIgYXQgMDg6MzI6NDNBTSArMDEwMCwgTGVlIEpvbmVzIHdyb3RlOgo+PiBPbiAyOS8wNy8xMiAy MTo1MCwgTWFyayBCcm93biB3cm90ZToKPj4+IE9uIEZyaSwgSnVsIDI3LCAyMDEyIGF0IDAxOjQ1 OjU3UE0gKzAxMDAsIExlZSBKb25lcyB3cm90ZToKPgo+Pj4+ICsJCXBjbTogdXg1MDAtcGNtIHsK Pj4+PiArCQkJY29tcGF0aWJsZSA9ICJzdGVyaWNzc29uLHV4NTAwLXBjbSI7Cj4+Pj4gKwkJfTsK Pj4+PiArCj4KPj4+IE9uZSBvZiB0d28gdGhpbmdzIGlzIHdyb25nIGhlcmUuICBFaXRoZXIgeW91 J3ZlIG5vdCBwcm92aWRlZCBhbnkKPj4+IGluZm9ybWF0aW9uIGFib3V0IHRoZSBoYXJkd2FyZSBz byB0aGUgZHJpdmVyIHdvbid0IGJlIGFibGUgdG8gd29yayBvdXQKPj4+IHdoYXQgdG8gdGFsayB0 byBvciB5b3UndmUgbm90IHByb3ZpZGVkIGFueSBkYXRhIHNvIHlvdSdyZSByZWdpc3RlcmluZyBh Cj4+PiBwdXJlbHkgdmlydHVhbCBMaW51eC1pbnRlcm5hbCBkZXZpY2UgdmlhIHRoZSBkZXZpY2Ug dHJlZS4KPgo+Pj4gT25jZSBtb3JlLCB0aGUgaWRlYSBoZXJlIGlzIHRvIGRlc2NyaWJlIHRoZSBo YXJkd2FyZSBub3QgdG8gZHVtcCBMaW51eCdzCj4+PiBpbnRlcm5hbCBkYXRhIHN0cnVjdHVyZXMg aW50byB0aGUgZGV2aWNlIHRyZWUuCj4KPj4gV2UgdXNlIGl0IHJlZ2lzdGVyIHRoZSBkcml2ZXIg Zm9yIHByb2JlKClpbmcuIEluIHRoZSBzYW1lIHdheSB3ZSBkbwo+PiBmb3IgdGhlIFBNVSBhbmQg UmVndWxhdG9ycy4gQWxsIHRocmVlIG9mIHdoaWNoIGFjdHVhbGx5IGJlbG9uZyB0byBhCj4+IGRp ZmZlcmVudCBoYXJkd2FyZSBibG9jay4gRG8geW91IGtub3cgb2YgYSBiZXR0ZXIgd2F5IHRvIHJl Z2lzdGVyCj4+IHRob3NlIGRldmljZXM/Cj4KPiBZb3UndmUgbm90IGlkZW50aWZpZWQgd2hpY2gg b2YgdGhlIHR3byBjYXNlcyBhYm92ZSB3ZSdyZSBpbi4uLiAgYXNzdW1pbmcKPiBpdCdzIGEgdmly dGFsIGRldmljZSBsb29rIGF0IGhvdyB0aGUgRFQgYmluZGluZ3MgZm9yIHRoZSBvdGhlciBwbGF0 Zm9ybXMKPiBhcmUgZG9pbmcgdGhpbmdzLgoKSSB0aG91Z2h0IGl0IHdvdWxkIGhhdmUgYmVlbiBv YnZpb3VzIGJ5IG15IHJlc3BvbnNlLiBUaGUgUE1VIHNlZW1zIHRvIGJlIAphIHZpcnR1YWwgZGV2 aWNlIHdpdGggbm8gcmVnaXN0ZXJzIG9yIElSUXMuCgpJJ3ZlIGZvdW5kIGEgRFQgd2hpY2ggc2Vl bXMgdG8gZG8gaXQgaW4gdGhlIHNhbWUgd2F5IGFzIEkgZG8gCidhcmNoL3Bvd2VycGMvYm9vdC9k dHMvcDEwMjJkcy5kdHMnLCBidXQgc29tZSBvdGhlcnMgY2FsbCBQQ00gCnJlZ2lzdHJhdGlvbiBm cm9tIHRoZSBDUFUtc2lkZSBEQUkgcHJvYmUoKS4gV291bGQgdGhhdCBiZSB5b3VyIHByZWZlcmVu Y2U/CgotLSAKTGVlIEpvbmVzCkxpbmFybyBTVC1Fcmljc3NvbiBMYW5kaW5nIFRlYW0gTGVhZApM aW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKRm9sbG93IExp bmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpBbHNhLWRldmVsIG1haWxpbmcgbGlzdApBbHNhLWRldmVs QGFsc2EtcHJvamVjdC5vcmcKaHR0cDovL21haWxtYW4uYWxzYS1wcm9qZWN0Lm9yZy9tYWlsbWFu L2xpc3RpbmZvL2Fsc2EtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Mon, 30 Jul 2012 15:26:58 +0100 Subject: [PATCH 13/18] ARM: ux500: Add ux500 PCM to DB8500 Device Tree In-Reply-To: <20120730134054.GC4468@opensource.wolfsonmicro.com> References: <1343393162-11938-1-git-send-email-lee.jones@linaro.org> <1343393162-11938-14-git-send-email-lee.jones@linaro.org> <20120729205001.GK4384@opensource.wolfsonmicro.com> <5016389B.4020003@linaro.org> <20120730134054.GC4468@opensource.wolfsonmicro.com> Message-ID: <501699B2.7030002@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 30/07/12 14:40, Mark Brown wrote: > On Mon, Jul 30, 2012 at 08:32:43AM +0100, Lee Jones wrote: >> On 29/07/12 21:50, Mark Brown wrote: >>> On Fri, Jul 27, 2012 at 01:45:57PM +0100, Lee Jones wrote: > >>>> + pcm: ux500-pcm { >>>> + compatible = "stericsson,ux500-pcm"; >>>> + }; >>>> + > >>> One of two things is wrong here. Either you've not provided any >>> information about the hardware so the driver won't be able to work out >>> what to talk to or you've not provided any data so you're registering a >>> purely virtual Linux-internal device via the device tree. > >>> Once more, the idea here is to describe the hardware not to dump Linux's >>> internal data structures into the device tree. > >> We use it register the driver for probe()ing. In the same way we do >> for the PMU and Regulators. All three of which actually belong to a >> different hardware block. Do you know of a better way to register >> those devices? > > You've not identified which of the two cases above we're in... assuming > it's a virtal device look at how the DT bindings for the other platforms > are doing things. I thought it would have been obvious by my response. The PMU seems to be a virtual device with no registers or IRQs. I've found a DT which seems to do it in the same way as I do 'arch/powerpc/boot/dts/p1022ds.dts', but some others call PCM registration from the CPU-side DAI probe(). Would that be your preference? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754661Ab2G3O1F (ORCPT ); Mon, 30 Jul 2012 10:27:05 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:64503 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753472Ab2G3O1D (ORCPT ); Mon, 30 Jul 2012 10:27:03 -0400 Message-ID: <501699B2.7030002@linaro.org> Date: Mon, 30 Jul 2012 15:26:58 +0100 From: Lee Jones User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Mark Brown CC: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, linus.walleij@stericsson.com, arnd@arndb.de, olalilja@yahoo.se, ola.o.lilja@stericsson.com, alsa-devel@alsa-project.org, lrg@ti.com Subject: Re: [PATCH 13/18] ARM: ux500: Add ux500 PCM to DB8500 Device Tree References: <1343393162-11938-1-git-send-email-lee.jones@linaro.org> <1343393162-11938-14-git-send-email-lee.jones@linaro.org> <20120729205001.GK4384@opensource.wolfsonmicro.com> <5016389B.4020003@linaro.org> <20120730134054.GC4468@opensource.wolfsonmicro.com> In-Reply-To: <20120730134054.GC4468@opensource.wolfsonmicro.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/07/12 14:40, Mark Brown wrote: > On Mon, Jul 30, 2012 at 08:32:43AM +0100, Lee Jones wrote: >> On 29/07/12 21:50, Mark Brown wrote: >>> On Fri, Jul 27, 2012 at 01:45:57PM +0100, Lee Jones wrote: > >>>> + pcm: ux500-pcm { >>>> + compatible = "stericsson,ux500-pcm"; >>>> + }; >>>> + > >>> One of two things is wrong here. Either you've not provided any >>> information about the hardware so the driver won't be able to work out >>> what to talk to or you've not provided any data so you're registering a >>> purely virtual Linux-internal device via the device tree. > >>> Once more, the idea here is to describe the hardware not to dump Linux's >>> internal data structures into the device tree. > >> We use it register the driver for probe()ing. In the same way we do >> for the PMU and Regulators. All three of which actually belong to a >> different hardware block. Do you know of a better way to register >> those devices? > > You've not identified which of the two cases above we're in... assuming > it's a virtal device look at how the DT bindings for the other platforms > are doing things. I thought it would have been obvious by my response. The PMU seems to be a virtual device with no registers or IRQs. I've found a DT which seems to do it in the same way as I do 'arch/powerpc/boot/dts/p1022ds.dts', but some others call PCM registration from the CPU-side DAI probe(). Would that be your preference? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog