From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45631)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cminyard@mvista.com>) id 1Svt4h-0005cF-R4
	for qemu-devel@nongnu.org; Mon, 30 Jul 2012 12:44:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cminyard@mvista.com>) id 1Svt4f-0008Vj-U4
	for qemu-devel@nongnu.org; Mon, 30 Jul 2012 12:44:07 -0400
Received: from mail-qa0-f52.google.com ([209.85.216.52]:41566)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cminyard@mvista.com>) id 1Svt4f-0008VS-QS
	for qemu-devel@nongnu.org; Mon, 30 Jul 2012 12:44:05 -0400
Received: by qabj34 with SMTP id j34so959431qab.4
	for <qemu-devel@nongnu.org>; Mon, 30 Jul 2012 09:44:05 -0700 (PDT)
Message-ID: <5016B9D2.2010401@mvista.com>
Date: Mon, 30 Jul 2012 11:44:02 -0500
From: Corey Minyard <cminyard@mvista.com>
MIME-Version: 1.0
References: <1342724013-1633-1-git-send-email-minyard@acm.org>
	<1342724013-1633-2-git-send-email-minyard@acm.org>
	<87obmxxntb.fsf@codemonkey.ws>
In-Reply-To: <87obmxxntb.fsf@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 01/18] smbios: Add a function to directly
 add an entry
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, minyard@acm.org

On 07/30/2012 10:37 AM, Anthony Liguori wrote:
> minyard@acm.org writes:
>
>> From: Corey Minyard <cminyard@mvista.com>
>>
>> There was no way to directly add a table entry to the SMBIOS table,
>> even though the BIOS supports this.  So add a function to do this.
>> This is in preparation for the IPMI handler adding it's SMBIOS table
>> entry.
>>
>> Signed-off-by: Corey Minyard <cminyard@mvista.com>
> I don't expect that hardware ever adds SMBIOS entries.  Rather, the BIOS
> adds the entries by probing the hardware.

Well, memory entries are added by QEMU, why not let the BIOS probe for 
that?  Plus, I really doubt that BIOSes on real systems probe for this.  
I'd guess they are hard-coded.

>
> So I think you should solve this in SeaBIOS, instead of trying to do it
> in QEMU.  I think that also solves the problem you have with
> pre-firmware init.

The user can pass the I/O base and IRQ values in on the QEMU command 
line, and they can be arbitrary values.  The BIOS is not going to be 
able to probe for those.

-corey